-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Fixes #140182 by checking file status before sending the prompt. #144131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Hey there @tronikos, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
homeassistant/components/google_generative_ai_conversation/__init__.py
Outdated
Show resolved
Hide resolved
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
break | ||
await asyncio.sleep(FILE_POLLING_INTERVAL_SECONDS) | ||
|
||
if uploaded_file.state == FileState.FAILED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could be here if PROCESSING or STATE_UNSPECIFIED. Shouldn't we raise an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't no? the loop above only breaks if it state is not UNSPECIFIED or PROCESSING, ergo ACTIVE or FAILED. It can also break if the timeout is reached, however that would be handled on line 129, and an unhandled Timeout Exception would be thrown.
Proposed change
Adds a step to the Generate Content Action in which the files that are not in ACTIVE state, are polled until they become so or the processing fails, if it fails a HomeAssistantError will be raised.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: