Add charging and preconditioning actions to Teslemetry #144184
Conversation
Bre77
changed the title
| "name": "Vehicle" | ||
| }, | ||
| "days_of_week": { | ||
| "description": "A comma separated list of days this schedule should be enabled. Example: \"Thursday,Saturday\". Also supports \"All\" and \"Weekdays\".", |
There was a problem hiding this comment.
"A comma-separated …"
Whenever two or more words are combined to form a unit with a single meaning that then modifies a following noun, they become a compound adjective and need to be joined together using a hyphen. (Source)
| "name": "Location" | ||
| }, | ||
| "start_enabled": { | ||
| "description": "If the vehicle should begin charging at the given start_time.", |
There was a problem hiding this comment.
In the UI the key names are not visible and are translated. So we need the field labels here:
"If the vehicle should begin charging at the given 'Start time'."
Similar for all the field references below.
| }, | ||
| "start_enabled": { | ||
| "description": "If the vehicle should begin charging at the given start_time.", | ||
| "name": "Start enabled" |
There was a problem hiding this comment.
But … Instead of separate switches to enable start_time and end_time: Could you instead make both fields optional so they simply come into effect when the user enables them using the check boxes next to them?
Proposed change
Add charging and preconditioning actions to Teslemetry
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: