Skip to content

Conversation

@scop
Copy link
Member

@scop scop commented May 4, 2025

Proposed change

Improve behavior when suspending/resuming the integration -- make more interactive entities aware of that, make problems better visible to users, make services easier to use (URL normalization).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 4, 2025

Hey there @fphammerle, mind taking a look at this pull request as it has been labeled with an integration (huawei_lte) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of huawei_lte can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign huawei_lte Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

"%s: ignored, integration suspended", self.entity_description.key
)
return
raise ServiceValidationError("Integration is suspended")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure if this (ditto in select and switch) is required/that useful now that the interactive entities' availability is updated based on if the parent router is suspended, but I guess it doesn't hurt.

scop added a commit that referenced this pull request May 4, 2025
@scop scop mentioned this pull request May 4, 2025
19 tasks
@joostlek
Copy link
Member

Would it make sense to just introduce the new core services to enable and disable an integration entry and deprecate these?

@scop
Copy link
Member Author

scop commented May 15, 2025

I'd gladly make use of something like those. However, implementing them is something I'll have to leave up to someone else to implement at this point. I feel I'm not up to date enough with core things nor have time to become so in the near future.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jul 14, 2025
@scop
Copy link
Member Author

scop commented Jul 15, 2025

Not stale.

@github-actions github-actions bot removed the stale label Jul 15, 2025
@emontnemery
Copy link
Contributor

@scop could you improve the tests, it seems there are no direct tests of the suspend service, it's tested indirectly in the button tests, and no tests at all of the resume service?

@CoMPaTech
Copy link
Member

@scop any chance you can look at the requested test improvements?

@frenck frenck marked this pull request as draft November 23, 2025 13:51
@frenck
Copy link
Member

frenck commented Nov 23, 2025

I've marked this PR a draft, as test changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@scop scop force-pushed the scop-huawei-lte-improve-suspended branch from 6f3a134 to a0b64db Compare November 23, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants