-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Improve huawei_lte suspend/resume related behavior #144200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey there @fphammerle, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| "%s: ignored, integration suspended", self.entity_description.key | ||
| ) | ||
| return | ||
| raise ServiceValidationError("Integration is suspended") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm not sure if this (ditto in select and switch) is required/that useful now that the interactive entities' availability is updated based on if the parent router is suspended, but I guess it doesn't hurt.
|
Would it make sense to just introduce the new core services to enable and disable an integration entry and deprecate these? |
|
I'd gladly make use of something like those. However, implementing them is something I'll have to leave up to someone else to implement at this point. I feel I'm not up to date enough with core things nor have time to become so in the near future. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Not stale. |
|
@scop could you improve the tests, it seems there are no direct tests of the suspend service, it's tested indirectly in the button tests, and no tests at all of the resume service? |
|
@scop any chance you can look at the requested test improvements? |
|
I've marked this PR a draft, as test changes are requested that need to be processed. Thanks! 👍 ../Frenck |
6f3a134 to
a0b64db
Compare
Proposed change
Improve behavior when suspending/resuming the integration -- make more interactive entities aware of that, make problems better visible to users, make services easier to use (URL normalization).
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: