-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Add miele devices dynamically #144216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add miele devices dynamically #144216
Conversation
what's the reason to switch from the pattern in your other PR (which I like, because it's still a bit shorter in each platform)? |
I have looked around for examples and there are pros and cons with all variants. This way the callback is triggered when data is complete in coordinator.data. I had difficulties with race conditions the other way. It could possibly have been solved but I started over and ended up with this variant that I beleive is easy to follow (at least for me - now...) |
Proposed change
When devices are added to the account they are automatically created in HA.
If they are removed they can be deleted manually from the UI. This can also be automated, but I think it should be done when we have some more experience if there are intermittent deletions in the API.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: