-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Add apply to make macros/callables useful in filters and tests #144227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 4508f5f. This is more performant without the raise and try/except. It's not worth paying that cost for every macro call.
LGTM. But since I am not too deep into templates, another pair of eyes would be nice. |
Any suggestions around other possible reviewers? |
@depoll Please have patience. There are many more older pull requests open than this one. There is no need to push for it. For more information about our review processes see: https://developers.home-assistant.io/docs/review-process Thanks 👍 ../Frenck |
Looks good to me! 👍 ../Frenck |
Breaking change
Proposed change
This PR implements the following architectural choice: home-assistant/architecture#1221
I frequently built utility macros for myself (and am excited for the folks supplying them through HACS), but one of my biggest frustrations has been the inability to use them as filters. This change makes it possible for people building such macros to use them (and any other callable) in settings where filters may be used by adding the
apply
filter.The simplest example is using a macro in a
map()
call:Which would print
["Hello, Alice!", "Hello, Bob!"]
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: