Skip to content

Fix Office 365 calendars to be compatible with rfc5545 #144230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented May 4, 2025

Proposed change

Add a small module to replace invalid Office 365 TZID values with something that is valid rfc5545 content and will be parsable by the underlying library. This moves the calendar parsing code to a module shared by config flow and coordinator and uses an integration specific exception rather than the exceptions in the underlying library to prepare for adding more validations/error checking.

Context: RFC5545 requires a calendar to be fully specified. Any TZID must be referenced in VTIMEZONE. This will remove the invalid timezone and force the date entry to be in the local time (given the behavior is undefined this seems most reasonable).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 4, 2025

Hey there @Thomas55555, mind taking a look at this pull request as it has been labeled with an integration (remote_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of remote_calendar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign remote_calendar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@allenporter allenporter added this to the 2025.5.0 milestone May 4, 2025
@allenporter allenporter marked this pull request as draft May 4, 2025 21:27
@allenporter allenporter removed this from the 2025.5.0 milestone May 4, 2025
@allenporter
Copy link
Contributor Author

I'm going to go with a different approach based on a new ical version. Will mark ready after the fix is in.

@allenporter allenporter force-pushed the remote-calendar-office-365 branch from 9f9c02f to 769294d Compare May 5, 2025 04:04
@allenporter allenporter marked this pull request as ready for review May 5, 2025 04:06
@allenporter
Copy link
Contributor Author

OK, I updated this to enable a compatibility layer in ical.

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allenporter 👍

@edenhaus edenhaus added this to the 2025.5.0 milestone May 5, 2025
@edenhaus edenhaus merged commit 3390dc0 into home-assistant:dev May 5, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote Calendar cannot parse Office365 calendar with invalid timezones
3 participants