-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Fix Office 365 calendars to be compatible with rfc5545 #144230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Office 365 calendars to be compatible with rfc5545 #144230
Conversation
Hey there @Thomas55555, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I'm going to go with a different approach based on a new ical version. Will mark ready after the fix is in. |
9f9c02f
to
769294d
Compare
OK, I updated this to enable a compatibility layer in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allenporter 👍
Proposed change
Add a small module to replace invalid Office 365
TZID
values with something that is valid rfc5545 content and will be parsable by the underlying library. This moves the calendar parsing code to a module shared by config flow and coordinator and uses an integration specific exception rather than the exceptions in the underlying library to prepare for adding more validations/error checking.Context: RFC5545 requires a calendar to be fully specified. Any
TZID
must be referenced inVTIMEZONE
. This will remove the invalid timezone and force the date entry to be in the local time (given the behavior is undefined this seems most reasonable).Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: