Skip to content

Fix Nanoleaf light state propagation after change from home asisstant #144291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 18, 2025

Conversation

tyriis
Copy link
Contributor

@tyriis tyriis commented May 5, 2025

Proposed change

As discussed in #97599 the propagation of the state change is not happening as expected within the nanoleaf integration. the update happens after a regular poll from the coordinator (instead of instant). By calling the integrated self.async_write_ha_state() the on/off toggle is propagated back to home assistant state store.
It still not solve the back propagation from the nanoleaf app, this will be done in another PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 5, 2025

Hey there @milanmeu, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (nanoleaf) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nanoleaf can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nanoleaf Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

joostlek commented May 6, 2025

Would it make sense to ask the coordinator to refresh the data instead?

@tyriis
Copy link
Contributor Author

tyriis commented May 6, 2025

Would it make sense to ask the coordinator to refresh the data instead?

I am not familiar with home-assistant core logic, is there a drawing (uml) on how it should work? (I copy pasted this from an external integration wich is working pretty well, govee). Do you have a reference? would be great if I can implement it the home assistant way.

@joostlek
Copy link
Member

joostlek commented May 6, 2025

well you can run self.coordinator.async_refresh() and it will automatically fetch new data and updates the light, so maybe that's better than just assuming it went well

@tyriis
Copy link
Contributor Author

tyriis commented May 6, 2025

hmm okay, so this is called in the light? will give it a try, thanks for the hint

@tyriis
Copy link
Contributor Author

tyriis commented May 7, 2025

I have updated the code, local tests are working well. Light state is reflected after toggle/change via home assistant

@tyriis
Copy link
Contributor Author

tyriis commented May 11, 2025

@joostlek any chance to get another review from you? 🙏

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the tests, mostly because we use end-to-end tests and that this integration did have no framework yet. I would be happy if we could add more tests though, but I now made sure that your change is properly tested.

@joostlek joostlek merged commit c1fcd8e into home-assistant:dev May 18, 2025
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants