-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
Ignore variants for pt raquel voice #144350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
if language == "pt-PT" and voice_id == "RaquelNeural": | ||
# RaquelNeural variants don't seem to be different | ||
# from the default voice | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So uh... why is it provided by Home Assistant Cloud in the first place?
As in, feels odd we need to filter it out this end...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a Portuguese native speaker, it sounds diferent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
Breaking change
Proposed change
Noticed that the Portugese variants for the Raquel voice do not sound different than the default voice. This filters them out.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: