Show issue for Airthings BLE devices with wrong connectivity mode set #155444
Conversation
|
Hey there @vincegio, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds detection and notification for Airthings BLE devices using SmartLink (hub) mode instead of Bluetooth mode, which is unsupported by Home Assistant.
Key changes:
- Detects connectivity mode from device sensors during data updates
- Creates a repair issue when SmartLink or unconfigured mode is detected
- Automatically removes the issue when device switches back to Bluetooth mode
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| coordinator.py | Added connectivity mode detection logic in _async_update_data to create/delete repair issues based on device mode |
| strings.json | Added issue translation strings for the SmartLink detection warning |
| }, | ||
| "issues": { | ||
| "smartlink_detected": { | ||
| "description": "The Airthings {device_name} is using SmartLink (hub), which isn’t supported in Home Assistant. Switch the device to Bluetooth mode in the Airthings app.", |
There was a problem hiding this comment.
According to the repair issue guidelines, the description should provide more specific, actionable steps for the user. Consider numbering the steps and adding what to expect after completing them, such as: 'To fix this issue: 1) Open the Airthings mobile app, 2) Navigate to your {device_name} device settings, 3) Select connectivity mode and switch to Bluetooth, 4) Wait for the device to reconnect, then 5) Restart Home Assistant to clear this warning.'
| "description": "The Airthings {device_name} is using SmartLink (hub), which isn’t supported in Home Assistant. Switch the device to Bluetooth mode in the Airthings app.", | |
| "description": "The Airthings {device_name} is using SmartLink (hub), which is not supported in Home Assistant. To fix this issue:\n1) Open the Airthings mobile app on your phone.\n2) Navigate to your {device_name} device settings.\n3) Find the connectivity mode option and select Bluetooth.\n4) Wait for the device to reconnect in Bluetooth mode.\n5) Restart Home Assistant to clear this warning.\n\nAfter completing these steps, your device will be available in Home Assistant and this warning will disappear.", |
Co-authored-by: Copilot <[email protected]>
|
Missing a label, could anyone add the |
| except Exception as err: | ||
| raise UpdateFailed(f"Unable to fetch data: {err}") from err | ||
|
|
||
| await self._check_connectivity_mode_issue(data) |
There was a problem hiding this comment.
Should we always check this during every update (which can be every 30s) or only during setup?
There was a problem hiding this comment.
Good question. Theoretically this could change at any time if the user changes the connectivity mode in the Airthings app, but it's very unlikely. One good thing about checking it every time is that if it changes we can remove the issue.
Ideally this should be something we check during setup + when the value changes.
Any input on how this can be improved? If I move it to setup, it won't remove the issue, unless I missed something 🤔
There was a problem hiding this comment.
I would argue that this is a test_init.py test, as it tests something that we expect to happen during the lifecycle of an integration (and we should not touch the coordinator directly as the coordinator is just a tool, not the end result
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
3 participants
Breaking change
Proposed change
Need to warn the user about wrong connectivity mode set for Corentium Home 2 and Wave Enhance. It was reported that CH2 is not advertising over BLE out of the box. You actually have to configure it in the Airthings app to make sure the BLE stays on. The user can also configure it to use SmartLink (hub) connectivity, which then disables BLE, unless you press on a button.
Will add similar feature for rest of the devices that have hub functionality later on, which requires another library update.
Would be nice to include this in the 2025.11.0 release!
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: