Add config flow for Emby integration #155745
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I've added a fairly basic ConfigFlow here, there isn't much validation performed (the underlying library doesn't seem to expose much functionality to help with validating credentials etc. but it does seem like both could do with a bit of attention).
To do this, the dynamic entity creation and removal logic had to be removed (for now) as I fear it would introduce too many changes for a single PR. I'd like to overhaul the media_player platform too and create base entity / device classes but that will need to be done after this PR is complete and the device addition/removal logic is added back in (elsewhere).
As an aside, there is this custom integration out in the wild that currently doesn't work - https://community.home-assistant.io/t/new-emby-jellyfin-integration/576888
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: