Skip to content

Conversation

@wollew
Copy link
Contributor

@wollew wollew commented Nov 4, 2025

Proposed change

This PR provides a player sensor with the time stamp of the next scheduled alarm for this player. It is a follow-up to #154491 which provides binary sensors for player alarms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 4, 2025

Hey there @rajlaud, @pssc, @peteS-UK, mind taking a look at this pull request as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of squeezebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign squeezebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds player-level alarm sensors to the Squeezebox integration, complementing the existing server-level sensors. The new functionality includes three binary sensors for alarm states (active, snoozed, upcoming) and one timestamp sensor for the next scheduled alarm time.

Key changes:

  • Added player-based alarm sensors (binary sensors for alarm states and timestamp sensor for next alarm)
  • Refactored test setup to use platform-specific fixtures reducing code duplication
  • Introduced new sensor entity classes that follow the existing SqueezeboxEntity pattern

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
homeassistant/components/squeezebox/sensor.py Added player alarm timestamp sensor entity class and setup logic
homeassistant/components/squeezebox/binary_sensor.py Added player alarm binary sensor entities for active, snoozed, and upcoming states
homeassistant/components/squeezebox/const.py Added constants for new player alarm sensor keys
homeassistant/components/squeezebox/strings.json Added translation keys for the new alarm sensor entities
tests/components/squeezebox/test_sensor.py Added test coverage for player alarm sensor and refactored test structure
tests/components/squeezebox/test_binary_sensor.py Added comprehensive tests for player alarm binary sensors
tests/components/squeezebox/test_switch.py Fixed incorrect docstring describing media_player instead of switch
tests/components/squeezebox/conftest.py Added alarm-related mock attributes to test player fixture

@wollew wollew marked this pull request as draft November 4, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant