System Nexa 2 Core Integration #159140

konsulten · 2025-12-15T18:52:42Z

Proposed change

Introduce System Nexa 2 from Nexa to Home Assistant

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Adding documentation for System Nexa 2 Integration home-assistant.io#42586
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

Dependency link: https://github.com/konsulten/python-sn2

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.
Update to Improv Wifi Config flow for 2.3 changes #159222
Assign unique IDs to IoTaWatt output sensors #158995

home-assistant

Hi @konsulten

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2025-12-15T18:52:48Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

.devcontainer/devcontainer.json

MartinHjelmare · 2025-12-16T18:36:28Z

Please address the bot comment.

#159140 (review)

Stale

konsulten · 2025-12-17T18:39:20Z

Please address the bot comment.

#159140 (review)

Done! Sensor and Light should have been removed now.

MartinHjelmare · 2025-12-17T18:56:02Z

homeassistant/components/systemnexa2/__init__.py

+) -> None:
+    """Handle settings updates."""
+    for entity in entry.runtime_data.config_entries:
+        if isinstance(entity, ConfigurationSwitch):


Please don't expose platform details directly outside the platform, like accessing the entity directly.

It's ok to register a callback from the platform that we call in a central place to let the entity know about a state update.

One way is to use the DataUpdateCoordinator in push mode.

https://developers.home-assistant.io/docs/integration_fetching_data#pushing-api-endpoints

Another way is to use our dispatch helper. A third way is to design some custom callback registration way.

Thank you will look into it!

Should be fixed now

MartinHjelmare · 2025-12-17T18:57:31Z

homeassistant/components/systemnexa2/__init__.py

+    except DeviceInitializationError as e:
+        raise ConfigEntryNotReady from e
+    if device.info_data is None:
+        return False


Is there any way to resolve this state (ConfigEntryError) for the user?

The only ones I can think of is that user would need to look over configuration over the actual device or that there is some device error that's making it unreachable on the network?

Or that if user had used IP for configuration host for the device it could have changed IP and needs IP address to be updated if it changed by ending DHCP lease or such. User could also have changed hostname of the devices so user would need to update configuration

When is device.info_data None?

Should never happen, it should raise a DeviceInitializationError if it fails to set it in the library. Writing a comment about it, or should it be an assert to just avoid mypy?

If it can't happen we can use an assert to tell mypy about it. Use an if TYPE_CHECKING: block.

Although the library only conditionally sets the attribute so technically it can happen.

https://github.com/konsulten/python-sn2/blob/1f181a9dc779d1f60dbb2ea5a8f69cace5e9fa9c/sn2/device.py#L370-L378

I'd suggest to try and improve the library so the logic and type annotations of the library matches reality.

Eg get_info will never return a falsy object according to the current type annotations in the library but we still check for that case.

Updated the library and removed the checks

homeassistant/components/systemnexa2/config_flow.py

MartinHjelmare · 2025-12-17T19:33:22Z

tests/components/systemnexa2/test_config_flow.py

+    }
+
+
+async def test_zeroconf_discovery(


I'm missing a test of already configured device.

homeassistant/components/systemnexa2/strings.json

…ve quality scale

konsulten · 2025-12-22T18:44:31Z

I hope I got the things mentioned in the comments. :)

…stead

konsulten · 2026-01-02T08:15:17Z

Should be ready for review now, not any planned changes to be done

joostlek · 2026-01-02T14:18:46Z

homeassistant/components/systemnexa2/const.py

+
+from homeassistant.const import Platform
+
+DOMAIN = "systemnexa2"


Is systemnexa2 a right domain name?

I think so at least, this is the corresponding company web page for the product line:
https://nexa.se/smarta-hem/system-nexa-2

What about the first nexa? What if they release a new one? Would nexa be a better domain?

(this is mostly about trying to understand as we can't change the domain once it's in, so I just want to make sure we disucssed it to make sure it's future proof)

I think it is its own API for these devices, Nexa is the brand name. There is another product line but its hub based. And it should be a separate domain

homeassistant/components/systemnexa2/__init__.py

joostlek · 2026-01-02T14:21:01Z

homeassistant/components/systemnexa2/config_flow.py

+        try:
+            info = await temp_dev.get_info()
+            device_id = info.information.unique_id
+            device_model = info.information.model
+            device_version = info.information.sw_version
+            if device_id is None or device_model is None or device_version is None:
+                return self.async_abort(
+                    reason="unsupported_model",
+                    description_placeholders={
+                        ATTR_MODEL: str(device_model),
+                        ATTR_SW_VERSION: str(device_version),
+                    },
+                )
+
+            self._discovered_device = _DiscoveryInfo(
+                name=info.information.name or "Unknown Name",
+                host=host_or_ip,
+                device_id=device_id,
+                model=device_model,
+                device_version=device_version,
+            )


Can we only keep things in the try block that can raise?

Good catch, it should only be the get_info. Updated.

joostlek · 2026-01-02T14:21:15Z

homeassistant/components/systemnexa2/config_flow.py

+                model=device_model,
+                device_version=device_version,
+            )
+        except Exception:  # noqa: BLE001


I would assume we would get something more specific than a bare exception?

homeassistant/components/systemnexa2/config_flow.py

homeassistant/components/systemnexa2/diagnostics.py

homeassistant/components/systemnexa2/entity.py

joostlek · 2026-01-02T14:26:58Z

homeassistant/components/systemnexa2/quality_scale.yaml

+  action-setup: done # No service actions in integration
+  appropriate-polling: done # No polling used, push only
+  brands: done
+  common-modules: done
+  config-flow-test-coverage: done
+  config-flow: done
+  dependency-transparency: done
+  docs-actions: done # No service actions in integration
+  docs-high-level-description: done
+  docs-installation-instructions: done
+  docs-removal-instructions: done
+  entity-event-setup: done # No events handled in entities
+  entity-unique-id: done
+  has-entity-name: done
+  runtime-data: done
+  test-before-configure: done
+  test-before-setup: done
+  unique-config-entry: done
+
+  # Silver
+  action-exceptions: done # No service actions in integration
+  config-entry-unloading: done
+  docs-configuration-parameters: done # No configuration parameters implemented.


please add the comments to the comment: part of the rule

should it be status: exempt or status: done in that case?

These read like exempt

Updated! And put the diagnostic and reconfigure flow in todo

joostlek · 2026-01-02T14:27:19Z

homeassistant/components/systemnexa2/switch.py

+    SystemNexa2SwitchEntityDescription(
+        key="433Mhz",
+        translation_key="433mhz",
+        entity_category=EntityCategory.CONFIG,
+    ),
+    SystemNexa2SwitchEntityDescription(
+        key="Cloud Access",
+        translation_key="cloud_access",
+        entity_category=EntityCategory.CONFIG,
+    ),
+    SystemNexa2SwitchEntityDescription(
+        key="Led",
+        translation_key="led",
+        entity_category=EntityCategory.CONFIG,
+    ),
+    SystemNexa2SwitchEntityDescription(
+        key="Physical Button",
+        translation_key="physical_button",
+        entity_category=EntityCategory.CONFIG,
+    ),


What does this show?

Hmm do you mean what is shown in the UI or something else? If in UI it shows configuration switches enabling/disabling the above functions

…ordinator

konsulten · 2026-01-03T12:05:05Z

Updated after review comments, hopefully all is answered, I resolved the comments which was just regarding code removal as there was so many unresolved comments it was hard to scroll in Github.

konsulten · 2026-01-12T08:07:30Z

@joostlek and @MartinHjelmare Is there any outstanding changes needed?

konsulten requested a review from a team as a code owner December 15, 2025 18:52

home-assistant bot previously requested changes Dec 15, 2025

View reviewed changes

home-assistant bot added cla-needed has-tests new-integration integration: systemnexa2 labels Dec 15, 2025

home-assistant bot marked this pull request as draft December 15, 2025 18:52

home-assistant bot added the quality-scale label Dec 15, 2025

home-assistant bot previously requested changes Dec 15, 2025

View reviewed changes

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Dec 15, 2025

MartinHjelmare reviewed Dec 15, 2025

View reviewed changes

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved

This was referenced Dec 15, 2025

Adding SystemNexa2 integration logo, icon and icon@2x home-assistant/brands#8735

Open

Adding documentation for System Nexa 2 Integration home-assistant/home-assistant.io#42586

Open

konsulten force-pushed the systemnexa2 branch 2 times, most recently from d038e84 to 3e4b1df Compare December 16, 2025 17:37

konsulten marked this pull request as ready for review December 16, 2025 17:55

MartinHjelmare marked this pull request as draft December 16, 2025 18:36

konsulten added 8 commits December 17, 2025 18:50

systemnexa

62f7ba9

systemnexa2 with conf test

ac00446

Updated quality_scale

e9d1900

Small comment removals, devcontainer change remove

d0d7008

Added brand nexa.json

e3d3c71

Strict typing added to System Nexa 2

b05e5ff

Removed so its only 1 platform introduced in first PR

4b4530a

bumped python-sn2 dep to 0.2.1

41c3d18

MartinHjelmare requested changes Dec 17, 2025

View reviewed changes

home-assistant bot marked this pull request as draft December 17, 2025 19:36

konsulten added 4 commits December 21, 2025 10:28

Updated to use DataUpdateCoordinator

7e0086f

Update setup of device and bumped python-sn2 to 0.2.3

4838d40

Removed some commented code and unused imports

d20d546

Update to 0.3.0 of python-sn2. Added some more tests. Trying to impro…

5cbc5e4

…ve quality scale

konsulten marked this pull request as ready for review December 22, 2025 18:43

home-assistant bot requested a review from MartinHjelmare December 22, 2025 18:43

konsulten marked this pull request as draft December 23, 2025 10:08

Improve quality scale

317cb97

konsulten marked this pull request as ready for review December 25, 2025 12:46

konsulten added 6 commits December 25, 2025 12:56

Convert some false positive unused parameters to pytest.useFixture in…

91fb2fa

…stead

Added missing coverage

c4d37a5

Updated to use aiohttp client session from HomeAssistant in python-sn2

2b965c1

Improving quality scale to silver

4966b36

Added reconfiguration-flow for IP Address/Hostname

edced91

Adding diagnostics, updated quality scale

5017110

joostlek requested changes Jan 2, 2026

View reviewed changes

home-assistant bot marked this pull request as draft January 2, 2026 14:27

konsulten added 2 commits January 2, 2026 15:29

Update after review comments

2b78578

Simplified by removing SystemNexa2RuntimeData as it contained only co…

0bbbab9

…ordinator

konsulten marked this pull request as ready for review January 3, 2026 08:13

home-assistant bot requested a review from joostlek January 3, 2026 08:13


		from homeassistant.const import Platform

		DOMAIN = "systemnexa2"

Uh oh!

System Nexa 2 Core Integration #159140

Are you sure you want to change the base?

System Nexa 2 Core Integration #159140

Uh oh!

Conversation

konsulten commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant bot commented Dec 15, 2025

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MartinHjelmare commented Dec 16, 2025

Uh oh!

konsulten commented Dec 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

konsulten commented Dec 22, 2025

Uh oh!

konsulten commented Jan 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

konsulten commented Dec 15, 2025 •

edited

Loading

MartinHjelmare Dec 17, 2025 •

edited

Loading