-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Adds a new core integration imou_life #159732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who would read this file? I think it is ported from the custom integration. I'd merge this file into the doc PR since it now has its own page.
| _LOGGER: logging.Logger = logging.getLogger(__package__) | ||
|
|
||
| # Limit parallel updates to prevent overwhelming the API | ||
| PARALLEL_UPDATES = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used?
| "codeowners": ["@Imou-OpenPlatform"], | ||
| "config_flow": true, | ||
| "dependencies": [], | ||
| "documentation": "https://next.home-assistant.io/integrations/imou_life", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you leave next here or the current url.
| status: exempt | ||
| comment: Integration does not register custom actions. | ||
| appropriate-polling: done | ||
| brands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The brand is imou. Do you have separate brand for Imou life? If not I'd recommend to rename this integration to imou and put the brand assets under this name. This integration already supports multiple classes of device. If ever you create another imou integration, you can create an alias.
But in any case you still have to put assets in the brands repo so that the documentation could be rendered with the logo.
Breaking change
Proposed change
Adds a new core integration imou_life
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: