Skip to content

Conversation

@Imou-OpenPlatform
Copy link

Breaking change

Proposed change

Adds a new core integration imou_life

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who would read this file? I think it is ported from the custom integration. I'd merge this file into the doc PR since it now has its own page.

_LOGGER: logging.Logger = logging.getLogger(__package__)

# Limit parallel updates to prevent overwhelming the API
PARALLEL_UPDATES = 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used?

"codeowners": ["@Imou-OpenPlatform"],
"config_flow": true,
"dependencies": [],
"documentation": "https://next.home-assistant.io/integrations/imou_life",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you leave next here or the current url.

status: exempt
comment: Integration does not register custom actions.
appropriate-polling: done
brands:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brand is imou. Do you have separate brand for Imou life? If not I'd recommend to rename this integration to imou and put the brand assets under this name. This integration already supports multiple classes of device. If ever you create another imou integration, you can create an alias.
But in any case you still have to put assets in the brands repo so that the documentation could be rendered with the logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants