Google Cast: detect state and attributes when device is doing active non-media casting #160819
+48
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes an issue where Cast devices running custom receiver applications (such as DashCast) are incorrectly reported as
offin Home Assistant.Currently, the integration checks
self._chromecast.is_idlebefore checking if a specificapp_idis active. Many custom apps do not implement the media namespace or report status in a waypychromecastexpects, resulting in the library reporting the device as idle/standby even when the app is visible on screen.This change reorders the checks in the
stateproperty. It now checks for a validapp_idbefore checking the idle status.app_idis present (and it is not the defaultAPP_BACKDROP), the state is reported asIDLE(orPLAYINGfor known unreliable apps).app_idattribute or stop the application.OFF.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: