Skip to content

Conversation

@tronikos
Copy link
Member

Breaking change

Proposed change

https://github.com/tronikos/opower/releases/tag/v0.16.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@c00w
Copy link
Contributor

c00w commented Jan 13, 2026

I think you need to check off the items in the checklist :).

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how the included PR tronikos/opower#165 could fix tronikos/opower#164.

The issue is that segment = None and segment.get("soFarUsageCharges") is tried, right?
That fails, of course. But after the change, it's (segment.get("soFarUsage") or {}), which would still fail, as we never even reach the or {} part due to raising before due to segment still being None.

EDIT: Actually, the issue is that the result from segment.get("soFarUsageCharges") is explicitly None, right? (not segment being None)

EDIT 2: Yep, can confirm by the amount of carets in the issue's trace, even though it's not formatted properly.

@tronikos
Copy link
Member Author

In an unrelated issue tronikos/opower#114 (comment) someone posted the full JSON response that shows which fields are null/None so I think the fix should work.

@tronikos tronikos merged commit 51701ca into home-assistant:dev Jan 13, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opower integration failing to start after updating to 2026.1.1 with "Failed setup, will retry: 'NoneType' object has no attribute 'get'"

3 participants