Fix state_attr_translated to preserve original type for non-string attributes#165320
Draft
Copilot wants to merge 2 commits intostate_attr_translatedfrom
Draft
Fix state_attr_translated to preserve original type for non-string attributes#165320Copilot wants to merge 2 commits intostate_attr_translatedfrom
state_attr_translated to preserve original type for non-string attributes#165320Copilot wants to merge 2 commits intostate_attr_translatedfrom
Conversation
21 tasks
Co-authored-by: piitaya <5878303+piitaya@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on state_attr_translated template filter
Fix Mar 11, 2026
state_attr_translated to preserve original type for non-string attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
state_attr_translatedwas unconditionally casting attribute values tostrbefore translation lookup, meaning numeric/boolean attributes would silently change type (e.g.,42→"42") even when no translation existed — breaking template comparisons.Changes
StateAttrTranslated.__call__: Skip translation and return the original value unchanged whenattr_valueis not astrorEnum; only those types have meaningful translation keysstr | NonetoAnyto reflect that non-string values pass through unmodifiedExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.