Improve error handling when addon unavailable for install/update#165352
Open
Improve error handling when addon unavailable for install/update#165352
Conversation
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Home Assistant’s Hass.io add-on manager error handling by using Supervisor “availability” errors to provide more informative exceptions when an add-on install/update cannot proceed due to platform/system constraints.
Changes:
- Convert Supervisor
AddonNotSupported*errors intoAddonErrormessages that include the underlying Supervisor reason for install/update. - Update add-on update flow to explicitly check Supervisor add-on availability and avoid extra add-on info fetches during backup creation.
- Adjust and expand tests to cover the new unsupported-availability error paths and updated call counts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| homeassistant/components/hassio/addon_manager.py | Catch unsupported add-on errors during install/update and add an availability check during update; refactor conversion of Supervisor models. |
| tests/components/hassio/test_addon_manager.py | Add parametrized tests for unsupported-availability errors and update expectations for reduced addon_info calls. |
| tests/components/conftest.py | Adjust add-on “not installed” fixture to simulate Supervisor “not found” behavior. |
0501186 to
87c56c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use availability API from Supervisor to provide more intuitive errors when install/update of an addon fails since the version is unavailable on the current system.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: