Skip to content

Fix Tesla Fleet token refresh handling for expired tokens#165354

Open
Bre77 wants to merge 4 commits intohome-assistant:devfrom
Bre77:conductor/tesla_fleet-token-refresh
Open

Fix Tesla Fleet token refresh handling for expired tokens#165354
Bre77 wants to merge 4 commits intohome-assistant:devfrom
Bre77:conductor/tesla_fleet-token-refresh

Conversation

@Bre77
Copy link
Contributor

@Bre77 Bre77 commented Mar 11, 2026

Proposed change

This change fixes Tesla Fleet token refresh handling for setup and runtime coordinator updates.
During setup, OAuth token failures are now mapped to Home Assistant OAuth exceptions and product fetching is retried with the existing region-discovery fallback.
During runtime refreshes, invalid or expired access tokens now invalidate the cached expires_at value so the next request triggers token refresh instead of forcing immediate reauthentication.
The test suite was expanded to cover OAuth refresh exceptions and recovery behavior for both vehicle and energy coordinators.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Tesla Fleet integration’s token refresh/error handling to better distinguish setup-time OAuth failures from runtime token expiry, and expands test coverage for these behaviors.

Changes:

  • Refactors setup product fetching into _async_get_products() with consistent region fallback and explicit mapping of OAuth refresh exceptions to Home Assistant config-entry exceptions.
  • Updates coordinators to treat InvalidToken/OAuthExpired as recoverable at runtime by invalidating cached expires_at to trigger a refresh on the next request, instead of forcing reauthentication.
  • Expands/updates tests to cover OAuth refresh exceptions during setup and recovery behavior for vehicle and energy coordinators.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/tesla_fleet/__init__.py Adds _async_get_products() and maps OAuth refresh failures to ConfigEntryAuthFailed/ConfigEntryNotReady during setup with region fallback.
homeassistant/components/tesla_fleet/coordinator.py Invalidates cached token expiry on InvalidToken/OAuthExpired so runtime updates can recover via refresh, while preserving reauth behavior for LoginRequired.
tests/components/tesla_fleet/test_init.py Updates setup/runtime error parametrization and adds recovery tests asserting expires_at invalidation and subsequent coordinator recovery.

Copilot AI review requested due to automatic review settings March 11, 2026 21:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants