Fix wemo tests for Python 3.14.3#165768
Merged
frenck merged 1 commit intohome-assistant:devfrom Mar 17, 2026
Merged
Conversation
Contributor
|
Hey there @esev, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WeMo integration and its tests to address failures seen under Python 3.14.3, primarily by ensuring entity state writes complete before assertions run and by making coordinator shutdown more defensive.
Changes:
- Add additional event-loop drains in WeMo tests to allow state updates triggered from executor threads to fully flush.
- Update WeMo coordinator shutdown logic to safely handle cases where setup/registration did not complete.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/components/wemo/test_light_dimmer.py | Adds additional loop flushes after service calls to stabilize brightness/state assertions. |
| tests/components/wemo/entity_test_helpers.py | Adds additional loop flushes after update calls to stabilize “unavailable” assertions. |
| homeassistant/components/wemo/coordinator.py | Makes shutdown resilient when device_id was never set due to early failure. |
You can also share your feedback on Copilot code review. Take the survey.
71 tasks
frenck
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
In response to #162263, this PR fixes the 5 failing
wemotests:Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: