Skip to content

Implement current setpoint method in actron air integration#169358

Merged
joostlek merged 4 commits intohome-assistant:devfrom
kclif9:Implement-current_setpoint-method-in-actron-air-integration
Apr 29, 2026
Merged

Implement current setpoint method in actron air integration#169358
joostlek merged 4 commits intohome-assistant:devfrom
kclif9:Implement-current_setpoint-method-in-actron-air-integration

Conversation

@kclif9
Copy link
Copy Markdown
Contributor

@kclif9 kclif9 commented Apr 28, 2026

Proposed change

Currently the integration defaults to the COOL setpoint in all climate entities, however this is inaccurate in HEAT mode.
This PR utilises the current_setpoint method implemented in the actron-neo-api library v0.5.6 (HA PR #169357) to show the end user the correct temperature setpoint when the HEAT mode.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @JagadishDhanamjayam, mind taking a look at this pull request as it has been labeled with an integration (actron_air) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of actron_air can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign actron_air Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@kclif9
Copy link
Copy Markdown
Contributor Author

kclif9 commented Apr 28, 2026

Waiting until #169357 is approved before pushing this from draft to a review state

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Actron Air integration to report the correct climate target temperature by using the upstream library’s “current setpoint” (so HEAT mode no longer displays the COOL setpoint).

Changes:

  • Bump actron-neo-api to 0.5.6 across the integration manifest and generated requirements files.
  • Switch system and zone target_temperature to use current_setpoint instead of the COOL setpoint field.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
requirements_all.txt Bumps actron-neo-api to 0.5.6 in the full dependency set.
requirements_test_all.txt Bumps actron-neo-api to 0.5.6 in the test dependency set.
homeassistant/components/actron_air/manifest.json Pins integration requirement to actron-neo-api==0.5.6.
homeassistant/components/actron_air/climate.py Uses current_setpoint for target_temperature on system and zone entities.

Comment thread homeassistant/components/actron_air/climate.py
Copilot AI review requested due to automatic review settings April 28, 2026 11:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread homeassistant/components/actron_air/climate.py
Comment thread homeassistant/components/actron_air/climate.py
@kclif9 kclif9 marked this pull request as ready for review April 28, 2026 21:42
@joostlek joostlek added this to the 2026.5.0 milestone Apr 29, 2026
@joostlek joostlek merged commit a7a2387 into home-assistant:dev Apr 29, 2026
36 of 37 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Actron Air Que unable to set heat temperatures below 20 deg C

3 participants