Fix flaky cloud TTS and picotts streaming tests#169376
Merged
justanotherariel merged 2 commits intodevfrom Apr 28, 2026
Merged
Conversation
Wait for background tasks to complete after triggering streaming so the streaming background task that calls process_tts_stream finishes before assertions run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
home-assistant
Bot
added
cla-signed
code-quality
core
has-tests
integration: cloud
small-pr
Contributor
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Wait for background tasks to complete after retrieve_media so the streaming background task finishes before the test ends. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
epenet
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the reliability of the Home Assistant Cloud TTS URL test by ensuring Home Assistant background tasks complete before assertions run, preventing teardown-time failures from still-running streaming/conversion work.
Changes:
- Add
wait_background_tasks=Truewhen blocking after triggering the TTS proxy GET intest_get_tts_audio.
justanotherariel
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Wait for background tasks to complete after triggering the streaming GET in two TTS tests, so the background task that loads the streamed audio (and the ffmpeg conversion subprocess) finishes before assertions run / the test ends:
tests/components/cloud/test_tts.py::test_get_tts_audiotests/components/picotts/test_tts.py::test_tts_serviceIn both tests the TTS audio is loaded into the cache by a hass background task. The streaming GET (
await client.get(...)directly, or via the sharedretrieve_mediahelper) only awaits response headers — the streaming background task can still be in flight when the test body finishes. Plainasync_block_till_done()does not wait for background tasks, so the task can outlive the test and surface as teardown errors.The cloud failure was spotted in the failing CI job for #162263:
https://github.com/home-assistant/core/actions/runs/25057100718/job/73402201821?pr=162263
Adding
await hass.async_block_till_done(wait_background_tasks=True)after the streaming GET matches the pattern already used intests/components/tts/test_init.py.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.