Skip to content

Fix nobo_hub KeyError when a zone or component is removed#169378

Merged
joostlek merged 2 commits intohome-assistant:devfrom
oyvindwe:nobo_hub-fix-removed-zone-keyerror
Apr 28, 2026
Merged

Fix nobo_hub KeyError when a zone or component is removed#169378
joostlek merged 2 commits intohome-assistant:devfrom
oyvindwe:nobo_hub-fix-removed-zone-keyerror

Conversation

@oyvindwe
Copy link
Copy Markdown
Contributor

Proposed change

Removing a zone via the Nobø app causes the integration to raise KeyError the next time the hub pushes a state update:

File ".../nobo_hub/entity.py", line 34, in _handle_hub_update
    self._read_state()
File ".../nobo_hub/climate.py", line 148, in _read_state
    state = self._nobo.get_current_zone_mode(self._id, dt_util.now())
File ".../pynobo.py", line 1057, in get_zone_override_mode
    _LOGGER.debug('Current override for zone %s is %s', self.zones[zone_id]['name'], mode)
KeyError: '14'

The same crash exists for the NoboProfileSelector (zone id) and NoboTemperatureSensor (component serial) push paths.

This PR adds a guard in each platform's _read_state that marks the entity unavailable when its underlying zone (climate, select) or component (sensor) is no longer present in the hub's data, instead of dereferencing a missing key. Availability is restored on the next push update if the zone/component reappears.

Out of scope: dynamically adding entities for zones/components added on the hub, and removing the entity registry entries for removed ones. Those will follow as the dynamic-devices / stale-devices quality-scale work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration (nobo_hub) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nobo_hub can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nobo_hub Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Nobø Ecohub integration’s push-update handling to avoid KeyError crashes when a zone (climate/select) or component (sensor) is removed on the hub, by marking affected entities unavailable instead of dereferencing missing hub data.

Changes:

  • Add availability guards in climate/select/sensor entities’ _read_state when the backing zone/component no longer exists on the hub.
  • Add regression tests verifying entities transition to STATE_UNAVAILABLE after a pushed update when their zone/component is removed.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/nobo_hub/climate.py Guard missing zone IDs during _read_state to prevent push-update crashes and mark entity unavailable.
homeassistant/components/nobo_hub/select.py Guard missing zone IDs for week profile selector during _read_state to prevent push-update crashes and mark entity unavailable.
homeassistant/components/nobo_hub/sensor.py Guard missing component serials during _read_state to prevent push-update crashes and mark entity unavailable.
tests/components/nobo_hub/test_climate.py Add test asserting a removed zone results in STATE_UNAVAILABLE after push update.
tests/components/nobo_hub/test_select.py Add test asserting a removed zone results in STATE_UNAVAILABLE after push update.
tests/components/nobo_hub/test_sensor.py Add test asserting a removed component results in STATE_UNAVAILABLE after push update.

@joostlek joostlek merged commit 8fd3d0b into home-assistant:dev Apr 28, 2026
33 checks passed
@oyvindwe oyvindwe deleted the nobo_hub-fix-removed-zone-keyerror branch April 29, 2026 11:28
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants