Fix flaky mcp_server tests with Python 3.14.3#169385
Merged
allenporter merged 3 commits intodevfrom Apr 29, 2026
Merged
Conversation
Contributor
|
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flaky mcp_server test failures under Python 3.14.3 by ensuring the core homeassistant component is set up for all tests in the tests/components/mcp_server package.
Changes:
- Add an autouse pytest fixture to set up the
homeassistantcomponent before tests run.
21 tasks
Updated docstring for ensure_homeassistant_loaded fixture.
epenet
commented
Apr 28, 2026
| "codeowners": ["@allenporter"], | ||
| "config_flow": true, | ||
| "dependencies": ["homeassistant", "http", "conversation"], | ||
| "dependencies": ["http", "conversation"], |
Contributor
Author
There was a problem hiding this comment.
In production, "homeassistant" is always loaded first. It doesn't not need to be present in dependencies so I have removed it.
core/homeassistant/bootstrap.py
Line 147 in f3acae6
jbouwh
approved these changes
Apr 28, 2026
allenporter
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Alternative to #169385
Spotted in https://github.com/home-assistant/core/actions/runs/25057100718/job/73402201810?pr=162263
Needed for #162263
Under some circumstances, it seems that
conversationcan be loaded beforehomeassistantcomponent has finished loading.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: