Bump pyuptimerobot to 25.0.0#169572
Open
chemelli74 wants to merge 5 commits intohome-assistant:devfrom
Open
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
Bot
added
dependency
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @ludeeus, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
chemelli74
force-pushed
the
chemelli74-uptimerobot
branch
from
aca10f5 to
7082790
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UptimeRobot integration to work with pyuptimerobot 25.0.0 (including switch API changes) and adjusts tests to match the upstream library’s new constants/method names.
Changes:
- Bump
pyuptimerobotfrom24.0.1to25.0.0in manifest and requirements files. - Update the UptimeRobot switch implementation to use
async_pause_monitor/async_start_monitorwith shared exception handling via a new decorator. - Adjust tests for moved constants and add coverage for sensors when monitor status is missing.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/uptimerobot/utils.py |
Adds a decorator to centralize handling of UptimeRobot API exceptions for entity command methods. |
homeassistant/components/uptimerobot/switch.py |
Switch now calls async_pause_monitor/async_start_monitor instead of the old edit API. |
homeassistant/components/uptimerobot/sensor.py |
Returns None when monitor status is missing so state becomes unknown. |
homeassistant/components/uptimerobot/manifest.json |
Bumps integration requirement to pyuptimerobot==25.0.0. |
requirements_all.txt |
Pins pyuptimerobot to 25.0.0. |
requirements_test_all.txt |
Pins pyuptimerobot to 25.0.0 for tests. |
tests/components/uptimerobot/test_switch.py |
Updates some patches to new API methods/constants (but still has remaining outdated patches). |
tests/components/uptimerobot/test_sensor.py |
Adds test for missing monitor status; updates imports. |
tests/components/uptimerobot/test_config_flow.py / test_diagnostics.py / common.py |
Updates imports to pyuptimerobot.const for API path constants. |
Comments suppressed due to low confidence (1)
tests/components/uptimerobot/test_switch.py:62
- Update the remaining switch tests that still patch
async_edit_monitorto patchasync_pause_monitor/async_start_monitor, otherwise those error-path assertions won't exercise the code anymore after the switch implementation change.
"pyuptimerobot.UptimeRobot.async_pause_monitor",
return_value=mock_uptimerobot_api_response(
api_path=API_PATH_MONITOR_DETAIL, data=MOCK_UPTIMEROBOT_MONITOR_PAUSED
),
),
joostlek
approved these changes
May 3, 2026
joostlek
requested changes
May 3, 2026
| raise HomeAssistantError( | ||
| translation_domain=DOMAIN, | ||
| translation_key="api_exception", | ||
| translation_placeholders={"error": "Generic UptimeRobot exception"}, |
Member
There was a problem hiding this comment.
We shouldn't add a string as a placeholder as these strings can't be translated and that will look weird in an exception in a non-English UI
Contributor
Author
There was a problem hiding this comment.
Updated, even if was not changed in this PR ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix broken switches
release: https://github.com/ludeeus/pyuptimerobot/releases/tag/25.0.0
changelog: ludeeus/pyuptimerobot@24.0.1...25.0.0
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: