Skip to content

Fix grammar and clarity in samsungtv/strings.json#169574

Merged
chemelli74 merged 3 commits intohome-assistant:devfrom
SeifEddineMezned:fix-samsungtv-strings-grammar
Apr 30, 2026
Merged

Fix grammar and clarity in samsungtv/strings.json#169574
chemelli74 merged 3 commits intohome-assistant:devfrom
SeifEddineMezned:fix-samsungtv-strings-grammar

Conversation

@SeifEddineMezned
Copy link
Copy Markdown
Contributor

Breaking change

this PR is not a breaking change

Proposed change

This PR fixes a few grammar and wording issues in user-facing strings in homeassistant/components/samsungtv/strings.json.

  • Fixed missing comma and corrected verb tense in conditional sentences ("If you never connected" -> "If you have never connected ..., you should")
  • Fixed article and punctuation in error messages ("Host is invalid, please try again." -> "The host is invalid. Please try again.")

Type of change

  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: none
  • This PR is related to issue: none
  • Link to documentation pull request: none
  • Link to developer documentation pull request: none
  • Link to frontend pull request: none

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Copilot AI review requested due to automatic review settings April 30, 2026 20:14
@home-assistant home-assistant Bot added cla-signed code-quality integration: samsungtv small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 30, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign samsungtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves user-facing copy in the Samsung TV integration’s config flow strings to be clearer and grammatically correct.

Changes:

  • Refined invalid host/PIN error phrasing and punctuation.
  • Improved conditional wording in setup instructions (“If you have never connected…”).

Comment thread homeassistant/components/samsungtv/strings.json Outdated
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI review requested due to automatic review settings April 30, 2026 21:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves user-facing configuration flow strings for the samsungtv integration to make messages clearer and more consistent with shared Home Assistant translations.

Changes:

  • Replaced the integration-specific invalid_host message with the shared common::config_flow::error::invalid_host translation key.
  • Refined the invalid_pin error text for clearer grammar and punctuation.
  • Improved wording/grammar in the “never connected before” guidance shown during setup.

@chemelli74 chemelli74 added this to the 2026.5.0 milestone Apr 30, 2026
Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

@chemelli74 chemelli74 merged commit b52aaa7 into home-assistant:dev Apr 30, 2026
32 of 33 checks passed
@SeifEddineMezned
Copy link
Copy Markdown
Contributor Author

@chemelli74 thank you for your support

@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality integration: samsungtv Quality Scale: gold small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants