Add group support to WLED main light#169669
Open
mik-laj wants to merge 5 commits intohome-assistant:devfrom
Open
Add group support to WLED main light#169669mik-laj wants to merge 5 commits intohome-assistant:devfrom
mik-laj wants to merge 5 commits intohome-assistant:devfrom
Conversation
The main light now tracks its segment members via IntegrationSpecificGroup, keeping group_entities updated as segments are dynamically added or removed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
home-assistant
Bot
added
cla-signed
has-tests
integration: wled
new-feature
small-pr
Contributor
|
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds integration-specific grouping to the WLED “main” light entity so it exposes its segment lights via the standard group_entities capability attribute and stays in sync when segments change.
Changes:
- Add an
IntegrationSpecificGrouptoWLEDMainLightand update its members on coordinator updates. - Add a regression test verifying
group_entitiesupdates as segments are added/removed at runtime. - Update WLED light snapshots to include
group_entitiesin capabilities/attributes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/wled/light.py |
Introduces IntegrationSpecificGroup on the main light and updates member unique IDs from current segments. |
tests/components/wled/test_light.py |
Adds coverage for dynamic segment changes updating the main light’s group_entities. |
tests/components/wled/snapshots/test_light.ambr |
Updates snapshot expectations to include group_entities for the main light. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mik-laj
changed the title
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
N/A
Proposed change
The WLED main light controls the entire WLED device, while individual segments represent the LED strips connected to it. This PR exposes that relationship by making the main light an IntegrationSpecificGroup whose members are the segment lights.
As a result, the group_entities attribute on the main light lists all connected LED strip entities, and the group stays up to date as segments are added or removed at runtime.
Part of: #124271
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: