Fix mypy no-any-return in youtube access_token property#169674
Draft
TomFilsell wants to merge 1 commit intohome-assistant:devfrom
Draft
Fix mypy no-any-return in youtube access_token property#169674TomFilsell wants to merge 1 commit intohome-assistant:devfrom
TomFilsell wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves typing in the YouTube integration by replacing a type: ignore[no-any-return] with an explicit typing.cast when returning the OAuth access token.
Changes:
- Add
from typing import castto the YouTube API module. - Replace
# type: ignore[no-any-return]withcast(str, ...)in theaccess_tokenproperty return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests:
Hi there,
I'm just offering a minor suggestion to ensure stricter typing across the Youtube integration.
Proposed change
This PR removes a
# type: ignore[no-any-return]in the YouTube integration and replaces it with an explicitcast(str, ...)in theaccess_tokenproperty.The OAuth2 session token is typed as
dict[str, Any], which causesmypyto infer anAnyreturn type when accessingCONF_ACCESS_TOKEN. Previously this was silenced using atype: ignore, but replacing it with an explicit cast improves type safety and aligns with typing patterns I have seen used in other integrations (e.g. input_boolean).This change has no functional impact, but avoids suppressing type checking, makes the expected return type explicit, and is intended to support the broader effort toward stricter typing across integrations
Type of change
Additional information
ruff,mypy, and all tests pass locallyChecklist
ruff format homeassistant tests)