Skip to content

Fix mypy no-any-return in youtube access_token property#169674

Draft
TomFilsell wants to merge 1 commit intohome-assistant:devfrom
TomFilsell:fix/youtube-mypy-access-token
Draft

Fix mypy no-any-return in youtube access_token property#169674
TomFilsell wants to merge 1 commit intohome-assistant:devfrom
TomFilsell:fix/youtube-mypy-access-token

Conversation

@TomFilsell
Copy link
Copy Markdown

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Hi there,
I'm just offering a minor suggestion to ensure stricter typing across the Youtube integration.

Proposed change

This PR removes a # type: ignore[no-any-return] in the YouTube integration and replaces it with an explicit cast(str, ...) in the access_token property.

The OAuth2 session token is typed as dict[str, Any], which causes mypy to infer an Any return type when accessing CONF_ACCESS_TOKEN. Previously this was silenced using a type: ignore, but replacing it with an explicit cast improves type safety and aligns with typing patterns I have seen used in other integrations (e.g. input_boolean).

This change has no functional impact, but avoids suppressing type checking, makes the expected return type explicit, and is intended to support the broader effort toward stricter typing across integrations

Type of change

  • Code quality improvements to existing code or addition of tests

Additional information

  • No functional changes
  • ruff, mypy, and all tests pass locally

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

Copilot AI review requested due to automatic review settings May 3, 2026 02:34
@TomFilsell TomFilsell requested a review from joostlek as a code owner May 3, 2026 02:34
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FIls0010

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 3, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft May 3, 2026 02:34
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 3, 2026

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (youtube) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of youtube can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign youtube Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves typing in the YouTube integration by replacing a type: ignore[no-any-return] with an explicit typing.cast when returning the OAuth access token.

Changes:

  • Add from typing import cast to the YouTube API module.
  • Replace # type: ignore[no-any-return] with cast(str, ...) in the access_token property return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants