Skip to content

Add Celsius and Fahrenheit to Smartthings UNITS mapping#169686

Open
kernelpanic85 wants to merge 1 commit intohome-assistant:devfrom
kernelpanic85:patch-1
Open

Add Celsius and Fahrenheit to Smartthings UNITS mapping#169686
kernelpanic85 wants to merge 1 commit intohome-assistant:devfrom
kernelpanic85:patch-1

Conversation

@kernelpanic85
Copy link
Copy Markdown
Contributor

Proposed change

The SmartThings integration was logging a warning about invalid temperature units:

Entity sensor.refrigerator_cooling_setpoint is using native unit of measurement 'Fahrenheit' which is not a valid unit for the device class ('temperature')

The SmartThings API can return temperature units as either short form ("C", "F") or full words ("Celsius", "Fahrenheit"). The UNITS mapping in sensor.py only handled the short forms, causing the full word variants to pass through unmapped and trigger validation warnings.

Added mappings for "Celsius" and "Fahrenheit" to the UNITS dictionary in sensor.py, ensuring all temperature unit variants from the SmartThings API are correctly normalized to Home Assistant's UnitOfTemperature constants.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Added mappings for "Celsius" and "Fahrenheit" to the `UNITS` dictionary in `sensor.py`, ensuring all temperature unit variants from the SmartThings API are correctly normalized to Home Assistant's `UnitOfTemperature` constants.
Copilot AI review requested due to automatic review settings May 3, 2026 13:04
@kernelpanic85 kernelpanic85 requested a review from joostlek as a code owner May 3, 2026 13:04
@home-assistant home-assistant Bot added bugfix cla-signed integration: smartthings small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage labels May 3, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 3, 2026

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (smartthings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smartthings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smartthings Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes SmartThings temperature sensors emitting validation warnings when the SmartThings API reports temperature units as full words instead of short forms, by normalizing those units to Home Assistant’s UnitOfTemperature constants.

Changes:

  • Extend the SmartThings sensor unit normalization map to handle "Celsius" and "Fahrenheit" in addition to "C" and "F".

Comment on lines 1286 to +1288
"F": UnitOfTemperature.FAHRENHEIT,
"Celsius": UnitOfTemperature.CELSIUS,
"Fahrenheit": UnitOfTemperature.FAHRENHEIT,
@joostlek
Copy link
Copy Markdown
Member

joostlek commented May 3, 2026

Do you have device diagnostics for this device? Curious how that works

@kernelpanic85
Copy link
Copy Markdown
Contributor Author

Do you have device diagnostics for this device? Curious how that works
smartthings-01JYKN0WFFK3ENBB5KG49K7T24-Refrigerator-ebb5936ebfb7d3715279ada3df2216f3.json

Does this help?

@joostlek
Copy link
Copy Markdown
Member

joostlek commented May 3, 2026

Yes, I think it's weird because those values are not permitted values according to their spec iirc. You can check the spec at https://github.com/pySmartThings/capabilities/

@kernelpanic85
Copy link
Copy Markdown
Contributor Author

kernelpanic85 commented May 3, 2026

Yes, I think it's weird because those values are not permitted values according to their spec iirc. You can check the spec at https://github.com/pySmartThings/capabilities/

I'm not sure, maybe something changed? The log messages stopped after implementing this. If I look in the Smartthings app, it shows °F. If I look in the developer portal it's there with both, though the C is not right.

image

@joostlek
Copy link
Copy Markdown
Member

joostlek commented May 3, 2026

I mean more like, yes the fix would fix this, but this means that the SmartThings server doesn't respond like it promises to do, let me check this with them as well. I have a meeting with them tomorrow, we still have time until the release on wedensday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed integration: smartthings Quality Scale: bronze small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SmartThings Refrigerator Temperature Units

3 participants