-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add bronze quality scale to DNS IP #169688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Phil-Rad
wants to merge
4
commits into
home-assistant:dev
Choose a base branch
from
Phil-Rad:quality-scale/dnsip-bronze
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3cc58b6
Add bronze quality scale to DNS IP
Phil-Rad 6fc0d73
Implement runtime-data and test-before-setup for dnsip
Phil-Rad 7bbf24c
Close DNS resolvers on setup failure and unload
Phil-Rad 58c61fd
Test setup-time DNS error path and IPv6-only setup for dnsip
Phil-Rad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| rules: | ||
| action-setup: | ||
| status: exempt | ||
| comment: Integration does not register custom actions. | ||
| appropriate-polling: done | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: done | ||
| config-flow: done | ||
| dependency-transparency: done | ||
| docs-actions: | ||
| status: exempt | ||
| comment: Integration does not register custom actions. | ||
| docs-high-level-description: done | ||
| docs-installation-instructions: done | ||
| docs-removal-instructions: done | ||
| entity-event-setup: | ||
| status: exempt | ||
| comment: Entities do not subscribe to events; the sensor polls via async_update. | ||
| entity-unique-id: done | ||
| has-entity-name: done | ||
| runtime-data: | ||
| status: exempt | ||
| comment: Each WanIpSensor manages its own aiodns.DNSResolver instance and there is no shared state at the config-entry level. | ||
| test-before-configure: done | ||
| test-before-setup: | ||
| status: exempt | ||
| comment: The integration has no central connection to validate at setup; each sensor performs DNS resolution independently and reports availability via async_update. | ||
| unique-config-entry: done | ||
|
Comment on lines
+22
to
+25
|
||
| action-exceptions: | ||
| status: exempt | ||
| comment: Integration does not register custom actions. | ||
| config-entry-unloading: done | ||
| docs-configuration-parameters: todo | ||
| docs-installation-parameters: todo | ||
| entity-unavailable: todo | ||
| integration-owner: done | ||
| log-when-unavailable: todo | ||
| parallel-updates: todo | ||
| reauthentication-flow: | ||
| status: exempt | ||
| comment: DNS resolution does not require authentication. | ||
| test-coverage: todo | ||
| devices: todo | ||
| diagnostics: todo | ||
| discovery-update-info: | ||
| status: exempt | ||
| comment: DNS resolvers do not support discovery. | ||
| discovery: | ||
| status: exempt | ||
| comment: DNS resolvers do not support discovery. | ||
| docs-data-update: todo | ||
| docs-examples: todo | ||
| docs-known-limitations: todo | ||
| docs-supported-devices: | ||
| status: exempt | ||
| comment: Integration does not represent physical devices. | ||
| docs-supported-functions: todo | ||
| docs-troubleshooting: todo | ||
| docs-use-cases: todo | ||
| dynamic-devices: | ||
| status: exempt | ||
| comment: Integration does not represent physical devices. | ||
| entity-category: todo | ||
| entity-device-class: todo | ||
| entity-disabled-by-default: todo | ||
| entity-translations: todo | ||
| exception-translations: todo | ||
| icon-translations: todo | ||
| reconfiguration-flow: todo | ||
| repair-issues: todo | ||
| stale-devices: | ||
| status: exempt | ||
| comment: Integration does not represent physical devices. | ||
| async-dependency: done | ||
| inject-websession: | ||
| status: exempt | ||
| comment: Integration uses aiodns directly; no shared HTTP websession applies. | ||
| strict-typing: todo | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably fix that beforehand instead of exempting it.
We can create the resolver in setup, test the connection and attach it to config entry runtime to use later in the sensor (I don't see a need for a coordinator really)