Update Nest doorbell event to use standard DoorbellEventType.RING#169691
Open
allenporter wants to merge 1 commit intohome-assistant:devfrom
Open
Update Nest doorbell event to use standard DoorbellEventType.RING#169691allenporter wants to merge 1 commit intohome-assistant:devfrom
allenporter wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nest integration’s doorbell event entity to use the standardized ring event type instead of the Nest-specific doorbell_chime, aligning Nest with Home Assistant’s newer doorbell event model and related trigger/condition support.
Changes:
- Switch the Nest doorbell event entity metadata to advertise
ringas its supported event type. - Translate incoming Nest
DOORBELL_CHIMEmessages to the standardizedringevent type before firing the event entity. - Update Nest strings and event-platform tests to reflect the standardized doorbell event type.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/nest/event.py |
Changes the Nest event entity definition and runtime event mapping to emit the standardized doorbell event type. |
homeassistant/components/nest/strings.json |
Updates the event-type localization key for the Nest chime event entity to use the shared ring translation. |
tests/components/nest/test_event.py |
Adjusts event entity tests to expect ring in doorbell event capabilities and state attributes. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
If you are currently using the Event Entity event type
doorbell_chime, you need to replace it with the new standardized eventring.This change intends to standardize the event type across different integrations, so they can be seamlessly used in the new triggers and conditions.
Event types for device triggers are not changed.
Proposed change
Update Nest Doorbell event entity to use the standard new event type.
Doorbell event entities now have a standard
ringevent type. Integrations that useEventDeviceClass.DOORBELLmust includeDoorbellEventType.RINGin theirevent_typeslist.See https://developers.home-assistant.io/blog/2026/04/15/doorbell-standard-event-type
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: