Skip to content

Update Nest doorbell event to use standard DoorbellEventType.RING#169691

Open
allenporter wants to merge 1 commit intohome-assistant:devfrom
allenporter:fix-nest-doorbell-ring-event
Open

Update Nest doorbell event to use standard DoorbellEventType.RING#169691
allenporter wants to merge 1 commit intohome-assistant:devfrom
allenporter:fix-nest-doorbell-ring-event

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

@allenporter allenporter commented May 3, 2026

Breaking change

If you are currently using the Event Entity event type doorbell_chime, you need to replace it with the new standardized event ring.
This change intends to standardize the event type across different integrations, so they can be seamlessly used in the new triggers and conditions.

Event types for device triggers are not changed.

Proposed change

Update Nest Doorbell event entity to use the standard new event type.

Doorbell event entities now have a standard ring event type. Integrations that use EventDeviceClass.DOORBELL must include DoorbellEventType.RING in their event_types list.

See https://developers.home-assistant.io/blog/2026/04/15/doorbell-standard-event-type

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2026.5.0 milestone May 3, 2026
Copilot AI review requested due to automatic review settings May 3, 2026 14:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Nest integration’s doorbell event entity to use the standardized ring event type instead of the Nest-specific doorbell_chime, aligning Nest with Home Assistant’s newer doorbell event model and related trigger/condition support.

Changes:

  • Switch the Nest doorbell event entity metadata to advertise ring as its supported event type.
  • Translate incoming Nest DOORBELL_CHIME messages to the standardized ring event type before firing the event entity.
  • Update Nest strings and event-platform tests to reflect the standardized doorbell event type.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/nest/event.py Changes the Nest event entity definition and runtime event mapping to emit the standardized doorbell event type.
homeassistant/components/nest/strings.json Updates the event-type localization key for the Nest chime event entity to use the shared ring translation.
tests/components/nest/test_event.py Adjusts event entity tests to expect ring in doorbell event capabilities and state attributes.

Comment thread homeassistant/components/nest/event.py
Comment thread homeassistant/components/nest/strings.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entity event.front_door_doorbell_chime is a doorbell event entity but does not support the 'ring' event type

2 participants