Skip to content

Matter fan: expose SET_SPEED for all fans via PercentSetting#169696

Open
lboue wants to merge 4 commits intohome-assistant:devfrom
lboue:matter_fan
Open

Matter fan: expose SET_SPEED for all fans via PercentSetting#169696
lboue wants to merge 4 commits intohome-assistant:devfrom
lboue:matter_fan

Conversation

@lboue
Copy link
Copy Markdown
Contributor

@lboue lboue commented May 3, 2026 •
edited
Loading

Proposed change

PercentSetting (attribute 0x0002) is a mandatory attribute of the Matter FanControl cluster, present on every fan that passes discovery — regardless of which optional features are advertised in the FeatureMap.

Previously, FanEntityFeature.SET_SPEED was only enabled when the MultiSpeed feature bit was set, so fans without MultiSpeed (e.g. range hoods, HVAC fans) could not have their speed controlled by percentage.

This PR moves SET_SPEED outside the kMultiSpeed guard so that percentage-based speed control is always exposed, matching how Apple Home handles the same devices (it always writes to PercentSetting).

When kMultiSpeed is present, speed_count is still derived from SpeedMax, giving the correct discrete step size. Without kMultiSpeed, HA defaults to 100 steps (1% granularity).

Affected devices

Fans that previously only had preset-mode control and now also gain SET_SPEED:

  • Longan Link thermostat fan
  • Extractor / range hoods

Tests

Added test_fan_set_percentage_without_multispeed to explicitly verify that a fan with FeatureMap = 0 (no MultiSpeed) exposes SET_SPEED, reports percentage_step = 1.0, and writes the correct value to PercentSetting when set_percentage is called.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 3, 2026 16:55
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: matter small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels May 3, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 3, 2026

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI reviewed May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Exposes FanEntityFeature.SET_SPEED for all Matter fans by treating PercentSetting as universally available, aligning Home Assistant fan speed control behavior with the Matter FanControl cluster’s mandatory attribute set.

Changes:

  • Always enable FanEntityFeature.SET_SPEED for Matter fans (regardless of kMultiSpeed).
  • Keep speed_count derived from SpeedMax only when kMultiSpeed is present; otherwise rely on the default (100).
  • Add a test verifying percentage control works for a fan with FeatureMap = 0, and update snapshots to reflect the new supported features and percentage attributes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/matter/fan.py Enables SET_SPEED unconditionally during feature calculation.
tests/components/matter/test_fan.py Adds coverage for set_percentage on non-MultiSpeed fans.
tests/components/matter/snapshots/test_fan.ambr Updates snapshots for newly exposed percentage attributes and feature flags.

Comment thread homeassistant/components/matter/fan.py
Comment on lines 255 to 262
self._attr_supported_features = FanEntityFeature(0)
# PercentSetting is always a mandatory attribute of the FanControl cluster,
# so percentage-based speed control is always available.
self._attr_supported_features |= FanEntityFeature.SET_SPEED
if feature_map & FanControlFeature.kMultiSpeed:
self._attr_supported_features |= FanEntityFeature.SET_SPEED
self._attr_speed_count = int(
self.get_matter_attribute_value(clusters.FanControl.Attributes.SpeedMax)
)
Copy link
Copy Markdown
Contributor Author

@lboue lboue May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread tests/components/matter/test_fan.py
@lboue lboue mentioned this pull request May 3, 2026
Open
@lboue lboue marked this pull request as ready for review May 3, 2026 17:11
@lboue lboue requested a review from a team as a code owner May 3, 2026 17:11
Copilot AI review requested due to automatic review settings May 3, 2026 17:11
Copilot AI reviewed May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

TheJulianJES
TheJulianJES reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheJulianJES TheJulianJES TheJulianJES left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bugfix by-code-owner cla-signed has-tests integration: matter Quality Scale: No score small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limited Fan Speed Control in Home Assistant (Matter Integration)

4 participants

@lboue @TheJulianJES @Luligu