Proxmox refactor to use UPTIME sensor#169704
Open
erwindouna wants to merge 1 commit intohome-assistant:devfrom
Open
Proxmox refactor to use UPTIME sensor#169704erwindouna wants to merge 1 commit intohome-assistant:devfrom
erwindouna wants to merge 1 commit intohome-assistant:devfrom
Conversation
home-assistant
Bot
added
breaking-change
cla-signed
has-tests
integration: proxmoxve
small-pr
Contributor
|
Hey there @Corbeno, @CoMPaTech, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Proxmox VE integration’s uptime sensors to use Home Assistant’s SensorDeviceClass.UPTIME semantics (boot timestamp) instead of reporting a numeric duration, and updates tests/snapshots accordingly.
Changes:
- Convert node/VM/container uptime sensors from
DURATION(seconds/hours) toUPTIME(datetime boot timestamp). - Update sensor entity typing to allow datetime native values for VM/container uptime.
- Stabilize snapshot testing by freezing time and updating the stored snapshots.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/proxmoxve/sensor.py |
Changes uptime sensors to return a boot timestamp (datetime) and sets device_class=UPTIME. |
tests/components/proxmoxve/test_sensor.py |
Freezes time to make uptime-derived timestamps deterministic in snapshots. |
tests/components/proxmoxve/snapshots/test_sensor.ambr |
Updates expected entity registry/state snapshots for new uptime behavior (timestamp states, no units/state_class). |
Comment on lines
128
to
140
| ProxmoxNodeSensorEntityDescription( | ||
| key="node_uptime", | ||
| translation_key="node_uptime", | ||
| value_fn=lambda data: data.node["uptime"], | ||
| device_class=SensorDeviceClass.DURATION, | ||
| native_unit_of_measurement=UnitOfTime.SECONDS, | ||
| suggested_unit_of_measurement=UnitOfTime.HOURS, | ||
| value_fn=( | ||
| lambda data: ( | ||
| (dt_util.utcnow() - timedelta(seconds=data.node["uptime"])) | ||
| if data.node["uptime"] is not None | ||
| else None | ||
| ) | ||
| ), | ||
| device_class=SensorDeviceClass.UPTIME, | ||
| entity_category=EntityCategory.DIAGNOSTIC, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| ), |
Comment on lines
128
to
140
| ProxmoxNodeSensorEntityDescription( | ||
| key="node_uptime", | ||
| translation_key="node_uptime", | ||
| value_fn=lambda data: data.node["uptime"], | ||
| device_class=SensorDeviceClass.DURATION, | ||
| native_unit_of_measurement=UnitOfTime.SECONDS, | ||
| suggested_unit_of_measurement=UnitOfTime.HOURS, | ||
| value_fn=( | ||
| lambda data: ( | ||
| (dt_util.utcnow() - timedelta(seconds=data.node["uptime"])) | ||
| if data.node["uptime"] is not None | ||
| else None | ||
| ) | ||
| ), | ||
| device_class=SensorDeviceClass.UPTIME, | ||
| entity_category=EntityCategory.DIAGNOSTIC, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Changes the Uptime sensor from duration in seconds to a timestamp uptime sensor. This is done for the node, VMs and containers.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: