Revert "Bump deebot-client to 18.2.0"#169705
Open
eshattow wants to merge 1 commit intohome-assistant:devfrom
Open
Revert "Bump deebot-client to 18.2.0"#169705eshattow wants to merge 1 commit intohome-assistant:devfrom
eshattow wants to merge 1 commit intohome-assistant:devfrom
Conversation
This reverts commit 39d3bc3.
home-assistant
Bot
added
cla-signed
integration: ecovacs
small-pr
Contributor
|
Hey there @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the deebot-client dependency bump for the Ecovacs integration to restore build compatibility with the repository’s current Rust toolchain constraints.
Changes:
- Revert
deebot-clientfrom18.2.0back to18.1.0in the integration manifest. - Revert
deebot-clientfrom18.2.0back to18.1.0inrequirements_all.txt. - Revert
deebot-clientfrom18.2.0back to18.1.0inrequirements_test_all.txt.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_test_all.txt | Pins deebot-client back to 18.1.0 for the full test requirements set. |
| requirements_all.txt | Pins deebot-client back to 18.1.0 for the full runtime requirements set. |
| homeassistant/components/ecovacs/manifest.json | Restores the Ecovacs integration’s deebot-client requirement to 18.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #169003
deebot-client fails to build in home-assistant/core due to rust 1.95 requirement being unobtanium. Core is still on Alpine 3.22 which is rust 1.87 and even Alpine 3.23 only has rust 1.91.1
Filed upstream bug DeebotUniverse/client.py#1571 to rollback rust version to 1.91 although that will still be a blocker until home-assistant/core moves to Alpine 3.23