Skip to content

Add flow it integration#175076

Open
albertogeniola wants to merge 74 commits into
home-assistant:devfrom
albertogeniola:add-flow-it-integration
Open

Add flow it integration#175076
albertogeniola wants to merge 74 commits into
home-assistant:devfrom
albertogeniola:add-flow-it-integration

Conversation

@albertogeniola

Copy link
Copy Markdown
Contributor

Proposed change

Add a new integration named FLOW-IT, for controlling VMC produced by the FLOW-IT company.
This is the first PR for this integration. As per perfect PR recommendations, I've only included a single PLATFORM (fan), on top of the necessary setup and config logic. As soon as this PR is merged, I'll add other platforms (sensor, binary_sensor, switch).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a brand-new Home Assistant integration, Flow-it, for controlling VMC ventilation units from the FLOW-IT company. As stated in the description, it intentionally ships only the fan platform plus the setup/config-flow scaffolding, with other platforms to follow in later PRs. The integration wraps the third-party flow-it-api library, supports user/zeroconf/YAML-import configuration, and combines a 30-second polling coordinator with a websocket push channel.

Changes:

  • Adds the flow_it integration (__init__.py, config_flow.py, entity.py, fan.py, const.py, manifest.json, strings.json, quality_scale.yaml) plus config-flow tests and generated/registry updates (zeroconf, integrations.json, config_flows, CODEOWNERS, requirements, mypy, strict-typing, codespell ignore).
  • Several unrelated files were committed by mistake and must be removed (index.html, index.html.1, =3.8.1, test_out.txt, test_out2.txt, and .github/workflows/manual-build-armv7.yml).
  • A few integration-level concerns: YAML import for a new integration, UpdateFailed raised during setup instead of ConfigEntryNotReady, reliance on private library internals, an inline coordinator, a shared base unique ID, and leftover switch/reauth strings.

Reviewed changes

Copilot reviewed 21 out of 27 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
homeassistant/components/flow_it/__init__.py Integration setup; flagged YAML import, UpdateFailed misuse, private websocket/state access, inline coordinator
homeassistant/components/flow_it/config_flow.py User/import/zeroconf flow; private _state access and manual already-configured check
homeassistant/components/flow_it/entity.py Base entity; shared unique ID across entities
homeassistant/components/flow_it/fan.py Fan platform; minor redundant bool()
homeassistant/components/flow_it/strings.json Strings; unused switch and reauth_successful entries
homeassistant/components/flow_it/{const,manifest,quality_scale}.{py,json,yaml} Constants, manifest (beta dep), quality scale
tests/components/flow_it/* Config-flow tests; helper missing type annotations
Generated/registry files zeroconf, integrations.json, config_flows, CODEOWNERS, requirements_all, mypy.ini, .strict-typing, .pre-commit-config
.github/workflows/manual-build-armv7.yml, index.html, index.html.1, =3.8.1, test_out.txt, test_out2.txt Unrelated/stray files committed by mistake — remove

Comment thread .github/workflows/manual-build-armv7.yml Outdated
Comment thread index.html Outdated
Comment thread index.html.1 Outdated
Comment thread =3.8.1 Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/entity.py Outdated
Comment thread homeassistant/components/flow_it/strings.json
Comment thread homeassistant/components/flow_it/strings.json Outdated
Comment thread homeassistant/components/flow_it/fan.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
Copilot AI review requested due to automatic review settings June 28, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 19 changed files in this pull request and generated 6 comments.

Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/entity.py Outdated
Comment thread homeassistant/components/flow_it/fan.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
Copilot AI review requested due to automatic review settings June 28, 2026 20:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 19 changed files in this pull request and generated 7 comments.

Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/quality_scale.yaml
Comment thread homeassistant/components/flow_it/entity.py Outdated
Comment thread homeassistant/components/flow_it/fan.py Outdated
Comment thread homeassistant/components/flow_it/strings.json
Copilot AI review requested due to automatic review settings June 29, 2026 07:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 20 changed files in this pull request and generated no new comments.

@albertogeniola albertogeniola force-pushed the add-flow-it-integration branch from 9a0b4c1 to 5e4e2ce Compare June 29, 2026 07:30

@erwindouna erwindouna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @albertogeniola! Here's an initial review. :)

Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
Comment thread tests/components/flow_it/test_config_flow.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft June 29, 2026 11:41
@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot AI review requested due to automatic review settings June 29, 2026 13:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 20 changed files in this pull request and generated 2 comments.

Comment thread tests/components/flow_it/test_config_flow.py Outdated
Comment thread homeassistant/components/flow_it/__init__.py
Copilot AI review requested due to automatic review settings June 29, 2026 20:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 20 changed files in this pull request and generated 4 comments.

Comment thread homeassistant/components/flow_it/fan.py Outdated
Comment thread homeassistant/components/flow_it/fan.py
Comment thread homeassistant/components/flow_it/strings.json
Comment thread homeassistant/components/flow_it/__init__.py
@home-assistant home-assistant Bot marked this pull request as draft July 4, 2026 19:43
Co-authored-by: Erwin Douna <e.douna@gmail.com>
Copilot AI review requested due to automatic review settings July 4, 2026 22:22
albertogeniola and others added 3 commits July 5, 2026 00:23
Co-authored-by: Erwin Douna <e.douna@gmail.com>
Co-authored-by: Erwin Douna <e.douna@gmail.com>
Co-authored-by: Erwin Douna <e.douna@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 6 comments.

Comment thread homeassistant/components/flow_it/config_flow.py
Comment thread homeassistant/components/flow_it/config_flow.py
Comment thread homeassistant/components/flow_it/strings.json
Comment thread homeassistant/components/flow_it/config_flow.py
Comment thread homeassistant/components/flow_it/config_flow.py
Comment on lines +29 to +35
self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, coordinator.data.state.name)},
name=coordinator.data.state.name,
manufacturer="FLOW-IT",
model="VMC",
sw_version=coordinator.data.state.data.alert.version,
)
Copilot AI review requested due to automatic review settings July 4, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/flow_it/config_flow.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 5, 2026 08:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 2 comments.

Comment thread homeassistant/components/flow_it/config_flow.py Outdated
Comment thread homeassistant/components/flow_it/config_flow.py
Copilot AI review requested due to automatic review settings July 5, 2026 18:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.

Comment thread homeassistant/components/flow_it/fan.py
Comment thread homeassistant/components/flow_it/coordinator.py Outdated
Comment thread homeassistant/components/flow_it/entity.py
Comment thread homeassistant/components/flow_it/fan.py
@albertogeniola albertogeniola marked this pull request as ready for review July 5, 2026 18:33
@home-assistant home-assistant Bot requested a review from erwindouna July 5, 2026 18:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 5, 2026 18:34
@albertogeniola

Copy link
Copy Markdown
Contributor Author

Hi @erwindouna ,
Thanks for the time taken for the last review. I've addressed all the points. Please let me know if this is okay now.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.

Comment on lines +36 to +43
info = await vmc.get_info()
await vmc.refresh_state()
if TYPE_CHECKING:
assert vmc.state is not None
return {
"title": info.hostname,
"unique_id": vmc.state.name,
}
"""Config flow for Flow-it integration."""

import logging
from typing import TYPE_CHECKING, Any, override
Comment on lines +1 to +5
{
"config": {
"abort": {
"already_configured": "[%key:common::config_flow::abort::already_configured_device%]"
},
Comment on lines +49 to +54
def __init__(
self,
hass: HomeAssistant,
config_entry: ConfigEntry,
vmc: FlowItVMCMachine,
) -> None:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants