Skip to content

Replace MonarchMoney Integration Dependency to MonarchMoneyCommunity#175721

Open
bradleyseanf wants to merge 7 commits into
home-assistant:devfrom
bradleyseanf:feat/monarch-money-community
Open

Replace MonarchMoney Integration Dependency to MonarchMoneyCommunity#175721
bradleyseanf wants to merge 7 commits into
home-assistant:devfrom
bradleyseanf:feat/monarch-money-community

Conversation

@bradleyseanf

@bradleyseanf bradleyseanf commented Jul 5, 2026

Copy link
Copy Markdown

Breaking change !!

Proposed change

Update the Monarch Money integration to use monarchmoneycommunity==1.5.1 and import the typed client from monarchmoneycommunity instead of typedmonarchmoney. Also add @bradleyseanf to the Monarch Money codeowners. As discussed with the codeowner here: jeeftor/monarchmoney-typed#107 to bring backing lib and typed client into one single project. As the owner of monarchmoneycommunity, I have added an optional typed client meant to be a drop in replacement for this Home Assistant integration shown at bradleyseanf/monarchmoneycommunity#39

Also - now that we are using my backing lib instead of the original monarchmoney which is no longer maintained, this has given me the opportunity to fix that when an MFA error occurs, it properly raises the LoginFailedException so we can get out of patch territory for upstream. This fix was in monarchmoneycommunity==v1.5.1 and properly adjusted in this PR as well with the dep replacement.

Type of change

  • Dependency upgrade

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running: python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Copilot AI review requested due to automatic review settings July 5, 2026 23:05
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade has-tests integration: monarch_money small-pr PRs with less than 30 lines. labels Jul 5, 2026
@home-assistant

home-assistant Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Hey there @jeeftor, mind taking a look at this pull request as it has been labeled with an integration (monarch_money) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of monarch_money can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign monarch_money Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR intends to migrate the Monarch Money integration off the typedmonarchmoney library and onto monarchmoneycommunity (consolidating the backing library and typed client into a single project), adds @bradleyseanf as a codeowner, and adjusts MFA failure handling in the config flow. However, the migration is incomplete: only the requirement metadata, codeowners, one config-flow except clause, and one test were changed, while every actual import of the removed packages was left untouched.

Changes:

  • Swap the declared requirement from typedmonarchmoney==0.7.0 to monarchmoneycommunity==1.5.0 in manifest.json and requirements_all.txt.
  • Add @bradleyseanf as a codeowner in manifest.json and CODEOWNERS.
  • Broaden the MFA-failure except in config_flow.py (and update the corresponding test) to also treat RequireMFAException/LoginFailedException as a bad MFA code.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
homeassistant/components/monarch_money/manifest.json Swaps requirement to monarchmoneycommunity==1.5.0 and adds new codeowner; requirement change is incomplete because imports still target the removed package.
requirements_all.txt Regenerated requirement pin for the new package; version (1.5.0) diverges from the PR description (1.5.1).
homeassistant/components/monarch_money/config_flow.py Broadens the MFA-failure handling to convert RequireMFAException/LoginFailedException into BadMFA.
tests/components/monarch_money/test_config_flow.py Updates the bad-MFA test to raise RequireMFAException instead of KeyError.
CODEOWNERS Adds @bradleyseanf to the Monarch Money integration and test ownership entries.

Comment thread homeassistant/components/monarch_money/manifest.json Outdated
Comment thread requirements_all.txt Outdated
@bradleyseanf bradleyseanf changed the title Feat/monarch money community Replace MonarchMoney Integration Dependency to MonarchMoneyCommunity Jul 5, 2026
@bradleyseanf bradleyseanf marked this pull request as ready for review July 6, 2026 00:13
Copilot AI review requested due to automatic review settings July 6, 2026 00:13
@bradleyseanf bradleyseanf marked this pull request as draft July 6, 2026 00:13
@bradleyseanf bradleyseanf force-pushed the feat/monarch-money-community branch from a0cc835 to ed5520a Compare July 6, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread tests/components/monarch_money/test_config_flow.py
Comment thread homeassistant/components/monarch_money/config_flow.py
Copilot AI review requested due to automatic review settings July 6, 2026 00:20

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0cc8358ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements_all.txt Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/monarch_money/config_flow.py
Copilot AI review requested due to automatic review settings July 6, 2026 00:28

@bradleyseanf bradleyseanf left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/2 Copilot suggestions applied

Comment thread homeassistant/components/monarch_money/config_flow.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@bradleyseanf bradleyseanf marked this pull request as ready for review July 6, 2026 00:52
Copilot AI review requested due to automatic review settings July 6, 2026 00:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed dependency Pull requests marked as a dependency upgrade has-tests integration: monarch_money Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants