You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey there @konikvranik, mind taking a look at this pull request as it has been labeled with an integration (rainbird) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of rainbird can trigger bot actions by commenting:
@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign rainbird Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.
CI Upload: ✅ Trusted Publisher attestation found (GitHub).
Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py. This is not a security review — only the cheap checks were run.
Async Safe: ⚠️pyrainbird/cloud/client.py:394: sync open() inside async def async_get_token of CachingTokenProvider (new in 6.4.0); not reachable from the AsyncRainbirdController/create_controller path that Home Assistant uses.
CI Upload: ✅ Trusted Publisher attestation found (GitHub).
Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py, pyrainbird/cloud/stream.py. This is not a security review — only the cheap checks were run.
Async Safe: ⚠️ New CachingTokenProvider in pyrainbird/cloud/client.py calls blocking open() at line 394 (read) and line 377 (write via sync helper) inside async def async_get_token(); however, these are off the hot path — an in-memory cache (self._token) short-circuits file I/O on all subsequent calls — and the HA rainbird integration does not use CachingTokenProvider at all.
CI Upload: ✅ Trusted Publisher attestation found (GitHub).
Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py, pyrainbird/cloud/stream.py, pyrainbird/encryption.py. This is not a security review — only the cheap checks were run.
Async Safe: ⚠️CachingTokenProvider.async_get_token (pyrainbird/cloud/client.py:394) opens a file via blocking open() directly inside an async def. This is only triggered on first call or token refresh (the in-memory self._token is returned on every subsequent call), so it is not on the per-request hot path — but it will block the event loop briefly during token cache initialization or expiry.
CI Upload: ✅ Trusted Publisher attestation found (GitHub).
Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py. This is not a security review — only the cheap checks were run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Bump
pyrainbirddependency version from6.3.1to6.5.0.Diff between 6.3.1 and 6.5.0
Key changes in
pyrainbird6.5.0:Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: