Skip to content

Bump pyrainbird to 6.5.0#175723

Open
allenporter wants to merge 4 commits into
home-assistant:devfrom
allenporter:bump-pyrainbird-version-169765
Open

Bump pyrainbird to 6.5.0#175723
allenporter wants to merge 4 commits into
home-assistant:devfrom
allenporter:bump-pyrainbird-version-169765

Conversation

@allenporter

@allenporter allenporter commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Bump pyrainbird dependency version from 6.3.1 to 6.5.0.

Diff between 6.3.1 and 6.5.0

Key changes in pyrainbird 6.5.0:

  • Fix LNK2 firmware crash by resolving encryption padding issues
  • Disable retry behavior by default on local clients (resolving test errors)
  • Remove connection pacing delay behavior from local clients

Type of change

  • Dependency upgrade
  • [] Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: rainbird small-pr PRs with less than 30 lines. labels Jul 5, 2026
@home-assistant

home-assistant Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Hey there @konikvranik, mind taking a look at this pull request as it has been labeled with an integration (rainbird) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rainbird can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rainbird Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Check requirements

Checked at commit 04eaee0.

⚠️ Some checks require attention — see the details below.

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pyrainbird 6.3.1 6.4.0 ☑️ ⚠️
📦 pyrainbird: 6.3.1 → 6.4.0
  • No Advisories: ✅ No active advisories reported by PyPI for version 6.4.0.
  • Not Yanked: ✅ Version 6.4.0 is a live (non-yanked) release.
  • Repo Public: ✅ https://github.com/allenporter/pyrainbird is publicly accessible.
  • CI Upload: ✅ Trusted Publisher attestation found (GitHub).
  • Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
  • Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py. This is not a security review — only the cheap checks were run.
  • PR Link: ❌ PR description should link to a changelog or compare URL on https://github.com/allenporter/pyrainbird that mentions both 6.3.1 and 6.4.0.
  • Async Safe: ⚠️ pyrainbird/cloud/client.py:394: sync open() inside async def async_get_token of CachingTokenProvider (new in 6.4.0); not reachable from the AsyncRainbirdController/create_controller path that Home Assistant uses.

Generated by Check requirements (AW) · 203.8 AIC · ⌖ 13.9 AIC · ⊞ 29.9K ·

@allenporter allenporter marked this pull request as draft July 5, 2026 23:34
@allenporter allenporter changed the title Bump pyrainbird to 6.4.0 Bump pyrainbird to 6.4.1 Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Check requirements

Checked at commit 57c7635.

⚠️ Some checks require attention — see the details below.

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pyrainbird 6.3.1 6.4.1 ☑️ ⚠️
📦 pyrainbird: 6.3.1 → 6.4.1
  • No Advisories: ✅ No active advisories reported by PyPI for version 6.4.1.
  • Not Yanked: ✅ Version 6.4.1 is a live (non-yanked) release.
  • Repo Public: ✅ https://github.com/allenporter/pyrainbird is publicly accessible.
  • CI Upload: ✅ Trusted Publisher attestation found (GitHub).
  • Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
  • Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py, pyrainbird/cloud/stream.py. This is not a security review — only the cheap checks were run.
  • PR Link: ✅ PR description links to the compare URL allenporter/pyrainbird@6.3.1...6.4.1 mentioning both 6.3.1 and 6.4.1.
  • Async Safe: ⚠️ New CachingTokenProvider in pyrainbird/cloud/client.py calls blocking open() at line 394 (read) and line 377 (write via sync helper) inside async def async_get_token(); however, these are off the hot path — an in-memory cache (self._token) short-circuits file I/O on all subsequent calls — and the HA rainbird integration does not use CachingTokenProvider at all.

Generated by Check requirements (AW) · 432.7 AIC · ⌖ 23.5 AIC · ⊞ 29.9K ·

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Check requirements

Checked at commit dd08e67.

⚠️ Some checks require attention — see the details below.

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pyrainbird 6.3.1 6.4.1 ☑️ ⚠️
📦 pyrainbird: 6.3.1 → 6.4.1
  • No Advisories: ✅ No active advisories reported by PyPI for version 6.4.1.
  • Not Yanked: ✅ Version 6.4.1 is a live (non-yanked) release.
  • Repo Public: ✅ https://github.com/allenporter/pyrainbird is publicly accessible.
  • CI Upload: ✅ Trusted Publisher attestation found (GitHub).
  • Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
  • Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py, pyrainbird/cloud/stream.py, pyrainbird/encryption.py. This is not a security review — only the cheap checks were run.
  • PR Link: ✅ PR description links to allenporter/pyrainbird@6.3.1...6.4.1, covering both 6.3.1 and 6.4.1.
  • Async Safe: ⚠️ CachingTokenProvider.async_get_token (pyrainbird/cloud/client.py:394) opens a file via blocking open() directly inside an async def. This is only triggered on first call or token refresh (the in-memory self._token is returned on every subsequent call), so it is not on the per-request hot path — but it will block the event loop briefly during token cache initialization or expiry.

Generated by Check requirements (AW) · 252.3 AIC · ⌖ 30.4 AIC · ⊞ 31.4K ·

@allenporter allenporter changed the title Bump pyrainbird to 6.4.1 Bump pyrainbird to 6.5.0 Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Check requirements

Checked at commit 1d3ebd0.

All requirements checks passed. ✅

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pyrainbird 6.3.1 6.5.0 ☑️
📦 pyrainbird: 6.3.1 → 6.5.0
  • No Advisories: ✅ No active advisories reported by PyPI for version 6.5.0.
  • Not Yanked: ✅ Version 6.5.0 is a live (non-yanked) release.
  • Repo Public: ✅ https://github.com/allenporter/pyrainbird is publicly accessible.
  • CI Upload: ✅ Trusted Publisher attestation found (GitHub).
  • Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
  • Security: ☑️ Baseline scan found nothing obvious in pyproject.toml, pyrainbird/__init__.py, pyrainbird/cloud/client.py. This is not a security review — only the cheap checks were run.
  • PR Link: ✅ PR description links to allenporter/pyrainbird@6.3.1...6.5.0, covering both 6.3.1 and 6.5.0.
  • Async Safe: ✅ No new blocking calls introduced in 6.3.1 → 6.5.0.

Generated by Check requirements (AW) · 209.7 AIC · ⌖ 30.4 AIC · ⊞ 29.9K ·

@allenporter allenporter marked this pull request as ready for review July 6, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: rainbird Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rainbird ESP-TM2 entities status fluctuates between unavailable and value

1 participant