-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid yaml #2546
Fix invalid yaml #2546
Conversation
The object keys need to be at the same indentation.
📝 WalkthroughWalkthroughThe pull request involves updates to the YAML style guide documentation, specifically addressing the "Default values" and "Service action targets" sections. Changes include correcting the indentation of the Changes
Notes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/documenting/yaml-style-guide.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (2)
docs/documenting/yaml-style-guide.md (2)
314-315
: LGTM!The indentation is correct and consistent with the guide's 2-space rule. The example effectively demonstrates the incorrect way of specifying entity IDs in service calls.
Line range hint
1-600
: Documentation is comprehensive and well-structured.The YAML style guide effectively covers all important aspects of YAML formatting with clear examples. The consistent use of "Good" and "Bad" examples helps readers understand the rules easily.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
The yaml here was invalid because the items in the object weren't indented at the same level. There was also a double space after the - list element indicator.
Thanks! |
Proposed change
The object keys need to be at the same indentation.
Type of change
Additional information
None
Summary by CodeRabbit
triggers
anddata
fields to align with established standards.