-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve documentation for field types available in addon config schemas #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve documentation for field types available in addon config schemas #2778
Conversation
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/add-ons/configuration.md (3)
247-247
: Avoid implying coercion from strings/numbers to boolean.Supervisor docs don’t state string/number coercion for booleans. Recommend describing this simply as a boolean and avoid promising parsing behavior.
Apply:
-- `bool`: `true`/`false`. Will attempt to parse strings and numbers as boolean values. +- `bool`: Boolean (`true`/`false`).
251-254
: Grammar fixes and tighten “port” semantics; drop unverifiable parsing claim.
- “an URL” → “a URL”.
- “A integer” → “An integer”.
- Prefer stating the valid range for ports and avoid promising string parsing.
- Optional: clarify
password
is masked in the UI.-- `url`: A string representing an URL. +- `url`: A string representing a URL. -- `password`: A string representing a password. +- `password`: A string representing a password (masked in the UI). -- `port`: A integer representing a port number. Will attempt to parse strings as port numbers. +- `port`: An integer representing a TCP/UDP port (1–65535).
258-267
: Example blocks read well; tiny consistency nit.Consider adding a brief lead-in sentence before the code fences (e.g., “For example:”) so the bullets render uniformly in Markdown lists.
- - Lists of some underlying element type: + - Lists of some underlying element type (for example): ... - - Nested dictionaries, e.g.: + - Nested dictionaries (for example):
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/add-ons/configuration.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (1)
docs/add-ons/configuration.md (1)
256-257
: Device filter wording LGTM.Matches current official guidance, including the
subsystem=tty
example for serial devices.See: Add-on configuration → “We support” list in the developer docs. (developers.home-assistant.io)
Proposed change
Improve the documentation for the different field types available for addon config schemas. Also explicitly mention how to define lists and dicts in the schema.
Type of change
Checklist
Additional information
Summary by CodeRabbit