Skip to content

Fix devcontainer on Windows #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yutamago wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix devcontainer on Windows #2920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Auto detect text files and perform LF normalization
* text=auto

# Always use linux style line endings
Comment on lines +1 to +4
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* text=auto applies attributes repo-wide, not just to .nvmrc. If the intent here is only to prevent CRLF in .nvmrc, consider limiting .gitattributes to that file to minimize global behavior changes.

Suggested change
# Auto detect text files and perform LF normalization
* text=auto
# Always use linux style line endings
# Ensure .nvmrc always uses LF (Unix) line endings

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says "Always use linux style line endings", but this rule only targets .nvmrc. Consider updating the comment for accuracy (and capitalize "Linux").

Suggested change
# Always use linux style line endings
# Use Linux-style line endings for .nvmrc

Copilot uses AI. Check for mistakes.
.nvmrc text eol=lf
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
20