Conversation
📝 WalkthroughWalkthroughDocumentation updates adding Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/core/entity/air-quality.md`:
- Line 32: The unit string for nitrogen_dioxide in the air-quality entity row
currently uses the Greek mu character "μ" — change it to the micro sign "µ" so
it matches the other sensor/number tables; update the value in the
nitrogen_dioxide row (the cell containing "μg/m³") to "µg/m³" and scan other
entity docs for any remaining "μg/m³" occurrences to standardize them all to
"µg/m³".
In `@docs/core/entity/climate.md`:
- Around line 76-88: Update the preset list in docs/core/entity/climate.md to
only include the actual Home Assistant built-in climate presets: ACTIVITY, AWAY,
BOOST, COMFORT, ECO, HOME, NONE, and SLEEP; remove the unsupported entries
GOING_TO_SLEEP, VACATION, and WAKE (or replace them with the correct equivalents
such as mapping GOING_TO_SLEEP→SLEEP and VACATION→AWAY) and, if desired, add a
short note that any other presets are custom to an integration and must be
explicitly defined there.
0924651 to
cc53e0f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/core/entity/sensor.md`:
- Line 62: Revert the documentation change that added "ppm" as a supported unit
for SensorDeviceClass.NITROGEN_DIOXIDE in the sensor.md entry and restore the
previous unit list (ppb, µg/m³) until the core PR `#162983` is merged; ensure the
sensor.md text no longer mentions "ppm" or any other units/features that depend
on the draft core change and leave a brief comment or TODO referencing the core
PR number to re-add the unit once that PR is merged.
There was a problem hiding this comment.
Pull request overview
This PR adds support for the ppm (parts per million) unit to the NITROGEN_DIOXIDE device class, expanding the supported units from ppb, µg/m³ to ppb, ppm, µg/m³. This change aligns with a fix in Home Assistant core (issue #150763 and PR #162983) where the missing ppm unit was causing integration issues.
Changes:
- Added
ppmto supported units forSensorDeviceClass.NITROGEN_DIOXIDEin sensor documentation - Added
ppmto supported units forNumberDeviceClass.NITROGEN_DIOXIDEin number documentation - Added unit documentation to the
nitrogen_dioxideproperty in air quality entity documentation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/core/entity/sensor.md | Added ppm to the supported units for SensorDeviceClass.NITROGEN_DIOXIDE |
| docs/core/entity/number.md | Added ppm to the supported units for NumberDeviceClass.NITROGEN_DIOXIDE |
| docs/core/entity/air-quality.md | Added supported units documentation (ppb, ppm, µg/m³) to the nitrogen_dioxide property description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Corrected the description for nitrogen_dioxide to remove an extra period.
|
There are no changes at all now in this PR. |
ppm to NITROGEN_DIOXIDE unitsppm to NITROGEN_DIOXIDE units
Proposed change
Added support for
ppmtoNITROGEN_DIOXIDEunitsType of change
Checklist
Additional information
ppmtoNITROGEN_DIOXIDEunits core#162983Summary by CodeRabbit
Documentation