Sort related automations, scripts and scenes on device info page #23740
+29
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbede
changed the title
MindFreeze
reviewed
Jan 15, 2025
silamon
requested changes
Mar 6, 2025
Comment on lines
+76
to
78
| private _toEntities = memoizeOne((entityIds: string[]) => | ||
| entityIds.map((entityId) => this.hass.states[entityId]) | ||
| ); |
There was a problem hiding this comment.
This change will defeat the purpose of MemoizeOne here. You can read about MemoizeOne here: https://www.npmjs.com/package/memoize-one#usage
Previously, we had individual MemoizeOne on entities, groups, automations, scripts, ...
So, if the related scripts don't change, memoize will return the cache result fast upon each rendering.
With these changes, only one MemoizeOne remains and since we fetch related entities, groups, automations, scripts and so on in sequence, it will never be able to return the cache.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Sort the related automations, scripts and scenes on the device info page as we already do in the more-info dialog.
Instead of copying the code for the sorting, I moved it to a central place (I hope the right one, otherwise please suggest the right one 🙂) and adjusted the related items in the more-info dialog to use it.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: