Skip to content

Conversation

@ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented Mar 20, 2025

Breaking change

Proposed change

Prevent saving an input_text helper with wrong values for min & max fields.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review March 20, 2025 21:12
@ildar170975 ildar170975 marked this pull request as draft March 21, 2025 06:09
@ildar170975 ildar170975 marked this pull request as ready for review March 21, 2025 20:19
@karwosts
Copy link
Member

Wouldn't this make more sense as backend validation with an error message? E.g. like already exists for min > max

image

@ildar170975

This comment was marked as abuse.

@ildar170975 ildar170975 marked this pull request as draft March 21, 2025 22:06
@ildar170975

This comment was marked as abuse.

@ildar170975 ildar170975 deleted the fix-text-255 branch December 14, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

input_text helper: it is possible to define a length > 255

2 participants