Fix duplicate 'triggered' text in Logbook context messages (#23083)#51508
Draft
ellegamee wants to merge 1 commit into
Draft
Fix duplicate 'triggered' text in Logbook context messages (#23083)#51508ellegamee wants to merge 1 commit into
ellegamee wants to merge 1 commit into
Conversation
MindFreeze
reviewed
Apr 14, 2026
Member
MindFreeze
left a comment
There was a problem hiding this comment.
This looks like it is removing more than just the "triggered" suffix
Contributor
|
I don't think this is the way to go. The triggered comes from a suffix in the replacement and I guess it makes sense to fix it properly. |
MindFreeze
requested changes
Apr 20, 2026
Member
MindFreeze
left a comment
There was a problem hiding this comment.
The original code extracted the trigger source from either item.context_source or from item.context_message.replace("triggered by ", "") and then localized it via localizeTriggerSource. The new code removes this entire branch, so the useful source of the trigger is no longer rendered at all. The fix removes information rather than removing the duplicate.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR improves the readability of Logbook entries by removing redundant "triggered" text that often appears twice when automations are run manually or via certain services.
In many languages (like Swedish or German), this creates grammatically awkward sentences where a localized "Triggered by" is followed by a hardcoded English "triggered" from the backend. By filtering out the exact string "triggered" from the context_message, the UI remains clean while still allowing other important context messages to be displayed.
Screenshots
Before in German:

After in German:

Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: