Skip to content

Show labels in ObjectSelector overview #51840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gjohansson-ST wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Show labels in ObjectSelector overview #51840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a99e2a
Labels in ObjectSelector overview
gjohansson-ST May 3, 2026
8dc75ec
Mods
gjohansson-ST May 12, 2026
1a51feb
Min
gjohansson-ST May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/components/ha-selector/ha-selector-object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,20 @@ export class HaObjectSelector extends LitElement {
.filter(Boolean)
.join(" · ");

const overviewLabels = this.selector.object!.overview_labels || false;

const labelField =
preferredLabel || Object.keys(this.selector.object!.fields!)[0];
Copy link
Copy Markdown
Member

@MindFreeze MindFreeze May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ! here is optimistic. fields may be undefined according to the type


const labelHeader = overviewLabels
? `${this._computeLabel({
name: labelField,
selector: fields[labelField]?.selector,
})}: `
Copy link
Copy Markdown
Member

@MindFreeze MindFreeze May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The : should really be part of the translation otherwise it won't work in all languages

Copy link
Copy Markdown
Member Author

@gjohansson-ST gjohansson-ST May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was really trying to avoid another field needed to be translated and instead just have a bool saying if it should display in the overview or not.

I'd think this probably looks ok even to remove : so it would just say Uncompensated value 5?

: "";

let description = "";
let descriptionHeader = "";

const descriptionField = this.selector.object!.description_field;
if (descriptionField && descriptionField in fields) {
Expand All @@ -108,6 +121,12 @@ export class HaObjectSelector extends LitElement {
descriptionSelector
)
: "";
descriptionHeader = overviewLabels
? `${this._computeLabel({
name: descriptionField,
selector: descriptionSelector,
})}: `
: "";
}

const reorderable = this.selector.object!.multiple || false;
Expand All @@ -123,10 +142,10 @@ export class HaObjectSelector extends LitElement {
></ha-svg-icon>
`
: nothing}
<div slot="headline" class="label">${label}</div>
<div slot="headline" class="label">${labelHeader}${label}</div>
${description
? html`<div slot="supporting-text" class="description">
${description}
${descriptionHeader}${description}
</div>`
: nothing}
<ha-icon-button
Expand Down
1 change: 1 addition & 0 deletions src/data/selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ export interface ObjectSelector {
label_field?: string;
description_field?: string;
translation_key?: string;
overview_labels?: boolean;
fields?: Record<string, ObjectSelectorField>;
multiple?: boolean;
} | null;
Expand Down
Loading