-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use presence detection in automations #34168
base: current
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThe recent updates enhance user navigation and documentation regarding presence detection in automation. A new navigation link has been added for direct access to "Presence detection in automations." Additionally, a new markdown file provides detailed guidance on implementing presence detection conditions in automations, improving the relevance and functionality for users looking to optimize their automation setups. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (7)
source/getting-started/presence-detection_in_automation.markdown (5)
6-6
: Clarify the introductory sentence.The introductory sentence can be made clearer by specifying the context.
- Now that you have [set up a device for presence detection](/getting-started/presence-detection/), you can use it in automations. + Now that you have [set up a device for presence detection](/getting-started/presence-detection/), you can use this device in your automations.
10-10
: Clarify the goal of the tutorial.The sentence can be rephrased for better clarity.
- In this tutorial, our goal is to run the [turning on the lights before sunset](/getting-started/automation/#turning-on-the-lights-before-sunset) automation only if we are home. + In this tutorial, our goal is to run the [turning on the lights before sunset](/getting-started/automation/#turning-on-the-lights-before-sunset) automation only when we are home.
19-19
: Clarify the navigation path.The navigation path can be made clearer by specifying the exact steps.
- Go to {% my automations title="**Settings** > **Automations & scenes**" %} and open the automation we created before, on [turning on the lights before sunset](/getting-started/automation/#turning-on-the-lights-before-sunset). + Go to {% my automations title="**Settings** > **Automations & Scenes**" %} and open the automation we created earlier on [turning on the lights before sunset](/getting-started/automation/#turning-on-the-lights-before-sunset).
31-31
: Correct the determiner.The determiner "these" is more appropriate in this context.
- If you want to run this automation only if a specific device is home, follow this steps: + If you want to run this automation only if a specific device is home, follow these steps:Tools
LanguageTool
[uncategorized] ~31-~31: The determiner “these” seems more likely in this context.
Context: ...ly if a specific device is home, follow this steps: - Select Entity, then *...(AI_EN_LECTOR_REPLACEMENT_DETERMINER)
35-35
: Remove unnecessary comma.The comma before "when" is unnecessary.
- Now, the light will only turn on, when this specific device is home. + Now, the light will only turn on when this specific device is home.Tools
LanguageTool
[typographical] ~35-~35: Usually, there’s no comma before “when”.
Context: ... - Now, the light will only turn on, when this specific device is home. ![...(IF_NO_COMMA)
source/getting-started/presence-detection.markdown (2)
Line range hint
6-6
:
Clarify the introductory sentence.The introductory sentence can be made clearer by specifying the context.
- Zone presence detection detects if people are within a certain zone, which can be valuable input for automation. + Zone presence detection determines if people are within a certain zone, which can be valuable input for automation.Tools
Markdownlint
76-76: Unused link or image reference definition: "condition"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
77-77: Unused link or image reference definition: "companion"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
Line range hint
12-12
:
Clarify the sentence.The sentence can be made clearer by specifying the context.
- You can do that if you have one of our [supported routers][routers]. + You can do this if you have one of our [supported routers][routers].Tools
Markdownlint
76-76: Unused link or image reference definition: "condition"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
77-77: Unused link or image reference definition: "companion"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the more interesting use case here to also trigger when you get home and the lights turn on?
|
👍
Don't agree with that statement. The automation is set up in an incorrect/inflexible way, making it hard to do now. From an automation perspective, this automation is a wrong practice from the get-go (which happens a lot in our community, I don't blame them, as our triggers contain to much "hidden condition logic" in them). In general, automation should trigger things, check conditions, and do actions. Right now, the automation has a mix-up of the sunset trigger that is "conditionally", making it hard to add more triggers as it will mess up stuff. A better approach, in general, is to trigger "sun" changes and have sunset as an actual condition already. Adding a presence condition and trigger at that point, will make the automation work in the case set here, but also when arriving home (as it will trigger an check the conditions). |
Thank you for the detailed explanation. Let me rework it. |
Proposed change
Add tutorial page to getting started
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Content Updates