Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit of measurement in A. O. Smith docs #35091

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

bdr99
Copy link
Contributor

@bdr99 bdr99 commented Oct 5, 2024

Proposed change

Change the unit of measurement for hot water status to percentage.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the description of the hot water availability sensor to report availability as a percentage.
    • Clarified integration metadata for the 2024.1 release while maintaining the same structure.
    • Retained instructions for connecting the water heater to Home Assistant via the A. O. Smith mobile app.
    • Continued support for various platforms and encouraged user feedback through GitHub links.

@home-assistant home-assistant bot added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Oct 5, 2024
@home-assistant
Copy link

home-assistant bot commented Oct 5, 2024

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link
Contributor

coderabbitai bot commented Oct 5, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request focus on updating the documentation for the A. O. Smith integration with Home Assistant. Key modifications include a revised description of the hot water availability sensor, which now indicates availability as a percentage. The integration's metadata has been clarified for the 2024.1 release, while maintaining support for various platforms and connection instructions. The list of known compatible models remains unchanged, and users are still encouraged to provide feedback through GitHub.

Changes

File Change Summary
source/_integrations/aosmith.markdown Updated description of hot water availability sensor to reflect percentage reporting; clarified metadata for 2024.1 release; maintained support information and connection instructions; known compatible models list unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant AOSmithApp

    User->>HomeAssistant: Connect to A. O. Smith integration
    HomeAssistant->>AOSmithApp: Request hot water availability
    AOSmithApp-->>HomeAssistant: Provide availability as percentage
    HomeAssistant-->>User: Display availability percentage
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit d9319a4
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6701adb7b9215b0008035505
😎 Deploy Preview https://deploy-preview-35091--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label Oct 5, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
source/_integrations/aosmith.markdown (1)

75-75: Approve the change and suggest adding blank lines.

The update to report hot water availability as a percentage aligns with the PR objective and improves clarity. However, to address the Markdownlint issue and improve readability, please add blank lines before and after the list of sensor entities.

Apply this diff to surround the list with blank lines:

 ### Sensor

 The following sensor entities are available:
+
 - Hot water availability (percentage)
 - Energy usage
+
 ## Disclaimer
🧰 Tools
🪛 Markdownlint

75-75: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between be9d5e1 and d9319a4.

📒 Files selected for processing (1)
  • source/_integrations/aosmith.markdown (1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/aosmith.markdown

75-75: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant