-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Document androidtv_remote.send_text service #37620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation update introduces a new action, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Integration
participant AndroidTV_Remote
User->>Integration: Invoke "androidtv_remote.send_text" action with parameters
Integration->>AndroidTV_Remote: Send text command (ensuring on-screen keyboard is closed)
AndroidTV_Remote-->>Integration: Acknowledge receipt of text
Integration-->>User: Return confirmation of action execution
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/androidtv_remote.markdown (2)
286-293
: Improve Note Terminology for Clarity
On line 291 the phrase "on screen keyboard" should be updated to "on‐screen keyboard" in order to match proper spelling and our documentation standards.🧰 Tools
🪛 LanguageTool
[uncategorized] ~291-~291: The adjective “on-screen” is spelled with a hyphen.
Context: ... TV device. {% note %} It requires the on screen keyboard to be closed first. {% endnote...(ON_SITE_HYPHEN)
294-297
: Fix Table Formatting for Data Attributes
The markdown table rows are missing trailing pipe characters. For example, update the line:-| `entity_id` | no | Name(s) of Android TV remote entities. +| `entity_id` | no | Name(s) of Android TV remote entities. |and similarly for the
text
row. This adjustment will ensure consistency with our table style guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
296-296: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
297-297: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/androidtv_remote.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/androidtv_remote.markdown
[uncategorized] ~291-~291: The adjective “on-screen” is spelled with a hyphen.
Context: ... TV device. {% note %} It requires the on screen keyboard to be closed first. {% endnote...
(ON_SITE_HYPHEN)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/androidtv_remote.markdown
296-296: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
297-297: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/androidtv_remote.markdown (1)
299-307
: Approve Example YAML for Service Usage
The provided YAML example clearly and correctly demonstrates the usage of the newandroidtv_remote.send_text
action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/androidtv_remote.markdown (1)
286-308
: Documentation clarity for theandroidtv_remote.send_text
sectionThe new section clearly outlines the purpose of the
androidtv_remote.send_text
action. The explanation, including the note about requiring the on-screen keyboard to be closed, the data attributes table, and the YAML example, is well-structured and adheres to the Home Assistant documentation style.A few suggestions:
- Consider adding a brief remark or link for troubleshooting in case users face issues with the on-screen keyboard.
- Verify that the table formatting renders correctly across different devices (you may want to test the preview if possible).
Overall, this addition improves the documentation for the new service.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/androidtv_remote.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tronikos 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Abílio Costa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can be merged once the parent PR is merged.
Proposed change
SSIA
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
Summary by CodeRabbit