-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Map card: add "prefix" & "suffix" options #38535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Map card: add "prefix" & "suffix" options #38535
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the map card's YAML configuration was updated to include two new optional string fields, Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_dashboards/map.markdown (2)
139-146
: Entity Configuration: New Prefix and Suffix Fields Added
The newprefix
andsuffix
fields are correctly added to the entity configuration block. Their optional nature and type (string
) are clearly specified, and the descriptions are consistent with related fields such asattribute
.It might be beneficial to include an example or a brief note in the documentation that illustrates how these fields affect the displayed label when
label_mode
is set toattribute
, to further aid user understanding.
172-179
: Geolocation Source: New Prefix and Suffix Fields Added
The addition ofprefix
andsuffix
fields in the geolocation sources configuration is well aligned with the updates in the entity configuration. The optional status, type declaration, and descriptions are consistent and clear.As with the entities section, consider adding an example usage or note in the documentation to demonstrate the impact of these settings for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
Added
prefix
&suffix
options (home-assistant/frontend#25033).Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
prefix
andsuffix
fields for both entity and source configurations, allowing customization of attribute value display when using attribute label mode.