-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add info on miele duration sensors #38601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough""" WalkthroughThe documentation for the Miele integration was updated to include three new sensor entities in the "Operation state" section. These sensors are "Elapsed time," "Remaining time," and "Start in," each providing time-related information about the current or upcoming program cycle. No code or functional changes were introduced; the update is limited to documentation. Changes
Sequence Diagram(s)No sequence diagram required as the changes are limited to documentation updates. Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)
89-91
: Refine descriptions for clarity and consistencyWhile the sensor entries are correct and follow the existing pattern, consider tweaking the phrasing to improve readability and include missing articles. For example:
- - **Elapsed time**: Shows the duration measured in minutes that current program has been running. + - **Elapsed time**: Shows the number of minutes that the current program has been running. - - **Remaining time**: The device calculates an estimate of how many minutes that are remaining in current program cycle. The number can go up and down during a program due to amount of dirt, time needed to heat incoming water, etc. + - **Remaining time**: Shows the estimated number of minutes remaining in the current program cycle. This value can fluctuate based on load dirtiness or water‑heating time. - - **Start in**: Shows number of minutes remaining to program start if the user has set a delayed start. + - **Start in**: Shows the number of minutes until a delayed program start, if configured.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/miele.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/miele.markdown (2)
89-91
: Remove unnecessary comma in conditional clause.Typically, no comma is needed before "if configured."
Apply this diff to improve readability:- - **Start in**: Shows the number of minutes until a delayed program start, if configured. + - **Start in**: Shows the number of minutes until a delayed program start if configured.🧰 Tools
🪛 LanguageTool
[typographical] ~91-~91: Usually, there’s no comma before “if”.
Context: ...of minutes until a delayed program start, if configured. {% enddetails %} ## Automa...(IF_NO_COMMA)
86-91
: Consider documenting sensor device class and units.For clarity and consistency with other Home Assistant integrations, we could note that these new sensors use the
duration
device class and report values in minutes. Example addition:- **Start in**: Shows the number of minutes until a delayed program start if configured. - _Device class_: `duration` - _Unit of measurement_: `min`This helps users understand how to use automations and templates with these sensors.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~88-~88: Possible missing comma found.
Context: ...ovens. Entities are created for up to 3 zones depending on the device capabilities. ...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~91-~91: Usually, there’s no comma before “if”.
Context: ...of minutes until a delayed program start, if configured. {% enddetails %} ## Automa...(IF_NO_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/miele.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown
[typographical] ~91-~91: Usually, there’s no comma before “if”.
Context: ...of minutes until a delayed program start, if configured. {% enddetails %} ## Automa...
(IF_NO_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
Description of three duration sensors
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit