-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add more sensors to Teslemetry #38651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Teslemetry integration has been updated to expand the list of available sensor entities under the "Vehicles" sensor domain. Many new sensors related to detailed vehicle subsystem telemetry have been added, including those for battery management, brake and drive unit parameters, inverter telemetry, HVAC power state, and various torque and voltage metrics. The list was also reordered, duplicate entries were removed, and new sensors are indicated as not enabled by default. No changes were made to code or other documentation sections. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User ->> Documentation: View Teslemetry "Vehicles" sensor entities
Documentation -->> User: Present expanded and updated list of sensor entities
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/teslemetry.markdown
(2 hunks)
🔇 Additional comments (6)
source/_integrations/teslemetry.markdown (6)
141-144
: New sensors for BMS and brick voltages are correctly inserted
The entries for “BMS state”, “Brake pedal position”, “Brick voltage max”, and “Brick voltage min” follow the existing alphabetical ordering and use consistent table formatting.
152-156
: Cruise and DC charging sensors added in correct order
The sensors “Cruise follow distance”, “Cruise set speed”, “Current speed limit”, “DC charging energy in”, and “DC charging power” are properly alphabetized and conform to naming conventions.
162-170
: Front-drive inverter/unit and HVAC sensors are well organized
The “Front drive inverter…” and “Front drive unit…” entries plus “HVAC power state” maintain consistent naming, default “No” state, and correct alphabetical placement.
177-184
: Primary rear drive sensors follow the established pattern
“Rear drive inverter…” and “Rear drive unit…” sensors are correctly grouped and ordered.
185-200
: Rear-left and rear-right drive sensors properly grouped
The “Rear left drive…” and “Rear right drive…” sensor entries are in correct alphabetical order within their respective groups.
205-205
: Secondary drive unit torque command is correctly positioned
The “Secondary drive unit torque command” entry follows “Scheduled departure time” and precedes “Shift state” as expected for alphabetical sequencing.
@@ -179,6 +220,7 @@ These are the entities available in the Teslemetry integration. Not all entities | |||
|Sensor|Tire pressure rear right|No| | |||
|Sensor|Traffic delay|No| | |||
|Sensor|Usable Battery level|No| | |||
|Sensor|Drive unit torque command|No| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Reorder 'Drive unit torque command' to maintain alphabetical order
The entry “Drive unit torque command” is currently placed after “Usable Battery level”, breaking the table’s alphabetical sequence. It should be moved under the “D” section—ideally right after “Distance to arrival” (line 157).
Apply this diff to remove and reinsert in the correct position:
@@ -223 +223
- |Sensor|Drive unit torque command|No|
@@ Vehicles table after line 157
+ |Sensor|Drive unit torque command|No|
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
|Sensor|Drive unit torque command|No| | |
--- a/source/_integrations/teslemetry.markdown | |
+++ b/source/_integrations/teslemetry.markdown | |
@@ -157 +157 | |
|Sensor|Distance to arrival|No| | |
+|Sensor|Drive unit torque command|No| | |
@@ -223 +223 | |
-|Sensor|Drive unit torque command|No| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Bre77 👍
Proposed change
Add more sensors to Teslemetry
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit