Skip to content

Add more sensors to Teslemetry #38651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Apr 21, 2025

Proposed change

Add more sensors to Teslemetry

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Expanded and updated the list of available vehicle sensor entities for the Teslemetry integration, including new telemetry sensors and improved organization within the documentation.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 21, 2025
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit cd5cd99
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6805f591fe672700081dc0bb
😎 Deploy Preview https://deploy-preview-38651--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 21, 2025

📝 Walkthrough

Walkthrough

The documentation for the Teslemetry integration has been updated to expand the list of available sensor entities under the "Vehicles" sensor domain. Many new sensors related to detailed vehicle subsystem telemetry have been added, including those for battery management, brake and drive unit parameters, inverter telemetry, HVAC power state, and various torque and voltage metrics. The list was also reordered, duplicate entries were removed, and new sensors are indicated as not enabled by default. No changes were made to code or other documentation sections.

Changes

File(s) Change Summary
source/_integrations/teslemetry.markdown Expanded and reorganized the list of "Vehicles" sensor entities, adding many new telemetry-related sensors.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    User ->> Documentation: View Teslemetry "Vehicles" sensor entities
    Documentation -->> User: Present expanded and updated list of sensor entities
Loading

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46be8fb and cd5cd99.

📒 Files selected for processing (1)
  • source/_integrations/teslemetry.markdown (2 hunks)
🔇 Additional comments (6)
source/_integrations/teslemetry.markdown (6)

141-144: New sensors for BMS and brick voltages are correctly inserted
The entries for “BMS state”, “Brake pedal position”, “Brick voltage max”, and “Brick voltage min” follow the existing alphabetical ordering and use consistent table formatting.


152-156: Cruise and DC charging sensors added in correct order
The sensors “Cruise follow distance”, “Cruise set speed”, “Current speed limit”, “DC charging energy in”, and “DC charging power” are properly alphabetized and conform to naming conventions.


162-170: Front-drive inverter/unit and HVAC sensors are well organized
The “Front drive inverter…” and “Front drive unit…” entries plus “HVAC power state” maintain consistent naming, default “No” state, and correct alphabetical placement.


177-184: Primary rear drive sensors follow the established pattern
“Rear drive inverter…” and “Rear drive unit…” sensors are correctly grouped and ordered.


185-200: Rear-left and rear-right drive sensors properly grouped
The “Rear left drive…” and “Rear right drive…” sensor entries are in correct alphabetical order within their respective groups.


205-205: Secondary drive unit torque command is correctly positioned
The “Secondary drive unit torque command” entry follows “Scheduled departure time” and precedes “Shift state” as expected for alphabetical sequencing.

@@ -179,6 +220,7 @@ These are the entities available in the Teslemetry integration. Not all entities
|Sensor|Tire pressure rear right|No|
|Sensor|Traffic delay|No|
|Sensor|Usable Battery level|No|
|Sensor|Drive unit torque command|No|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Reorder 'Drive unit torque command' to maintain alphabetical order
The entry “Drive unit torque command” is currently placed after “Usable Battery level”, breaking the table’s alphabetical sequence. It should be moved under the “D” section—ideally right after “Distance to arrival” (line 157).

Apply this diff to remove and reinsert in the correct position:

@@ -223 +223
- |Sensor|Drive unit torque command|No|
@@ Vehicles table after line 157
+ |Sensor|Drive unit torque command|No|
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
|Sensor|Drive unit torque command|No|
--- a/source/_integrations/teslemetry.markdown
+++ b/source/_integrations/teslemetry.markdown
@@ -157 +157
|Sensor|Distance to arrival|No|
+|Sensor|Drive unit torque command|No|
@@ -223 +223
-|Sensor|Drive unit torque command|No|

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Bre77 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants